https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- I may be doing something wrong, but once I've cancelled an order, the line goes grey and the option to add a note etc. is gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- My bad, the test plan should be: Test Plan: 1) Create a basket with an orderline 2) Delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! The situation arises when the record is deleted but the order is not canceled. I also wonder why we are preventing librarian's from adding notes to a canceled order. It seems like a useful feature. Outside the scope of this bug report though. Once this bug is fixed I'll probably submit a new enhancement for that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53472|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 53537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53537&action=edit Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53537|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53598&action=edit Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks for the followup Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.