https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 [Bug 42524] Option to calculate priorities based on reservedate when moving hold to a new record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looking at kohastructure.sql it will need to be changed for reserves, old_reserves, and tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198791&action=edit Bug 42558: Database updates Patch from commit d550ec2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199268&action=edit Bug 42558: Database updates Patch from commit dc99ff2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199270&action=edit Bug 42558: Ensure API returns hold_date as just a date Patch from commit fdde37c -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199273&action=edit Bug 42558: DBIC update [DO NOT PUSH] Patch from commit 15a2b6d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 199276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199276&action=edit Bug 42558: DBIC update [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks for the quick sign-off here David! I did realize there is more to do! Many tests are now failing with this bug applied. Setting back to ASSIGNED. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- As is I can place holds and exceed my daily limit: 1. APPLY PATCH, updatedatabase, restart_all 2. Administration > Circulation and fine rules, set Holds Allowed ( Daily ) to 1. 3. Notice you can place more than 1 hold. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199306&action=edit Bug 42558: Ensure API returns hold_date as just a date To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199309&action=edit Bug 42558: Use format_datetime in current_holds sub, instead of format_date Patch from commit 56ac1d1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199313&action=edit Bug 42558: Fix Reserve.t tests by updating reservedate calculations Patch from commit 8643b32 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199324&action=edit Bug 42558: Fix test comparisons in t/db_dependent/ILSDI_Services.t Patch from commit 5df6606 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. 5. Administration > Circulation and fine rules, set Holds Allowed ( Daily ) to 1. 6. Try to place additional holds, make sure the daily limits are respected. prove t/db_dependent/Circulation.t t/db_dependent/Holds/ExpireReservesAutoFill.t t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t t/db_dependent/Reserves/MultiplePerRecord.t t/db_dependent/ILSDI_Services.t t/db_dependent/Hold.t t/db_dependent/Reports/Guided.t t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Items.t t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.mathevet@inLibro.com --- Comment #25 from Chris Mathevet <chris.mathevet@inLibro.com> --- Everything works except the tests Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 512 (exited 2) Tests: 16 Failed: 2) Failed tests: 6, 16 Non-zero exit status: 2 t/db_dependent/api/v1/holds.t (Wstat: 24320 (exited 95) Tests: 12 Failed: 2) Failed tests: 11-12 Non-zero exit status: 95 Parse errors: Bad plan. You planned 20 tests but ran 12. t/db_dependent/HoldsQueue.t (Wstat: 24320 (exited 95) Tests: 49 Failed: 1) Failed test: 48 Non-zero exit status: 95 Parse errors: Bad plan. You planned 65 tests but ran 49. Files=12, Tests=395, 150 wallclock secs ( 0.23 usr 0.05 sys + 113.28 cusr 15.07 csys = 128.63 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chris Mathevet from comment #25)

Everything works except the tests

Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 512 (exited 2) Tests: 16 Failed: 2) Failed tests: 6, 16 Non-zero exit status: 2 t/db_dependent/api/v1/holds.t (Wstat: 24320 (exited 95) Tests: 12 Failed: 2) Failed tests: 11-12 Non-zero exit status: 95 Parse errors: Bad plan. You planned 20 tests but ran 12. t/db_dependent/HoldsQueue.t (Wstat: 24320 (exited 95) Tests: 49 Failed: 1) Failed test: 48 Non-zero exit status: 95 Parse errors: Bad plan. You planned 65 tests but ran 49. Files=12, Tests=395, 150 wallclock secs ( 0.23 usr 0.05 sys + 113.28 cusr 15.07 csys = 128.63 CPU) Result: FAIL

Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services? I cannot recreate these failures and all tests pass for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chris Mathevet from comment #27)

Created attachment 199517 [details] Failed test output

(In reply to Lucas Gass (lukeg) from comment #26)

...

(In reply to Chris Mathevet from comment #25)

Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services?

I cannot recreate these failures and all tests pass for me.

Hey, I did update the database and run yarn build. What do you mean by "restarting all services", do you use any special environment to test ? I rebooted my computer but still got the same result.

Here is the prove output.

I test in koha-testing-docker, I still cannot recreate any of the failures you describe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #30 from David Nind <david@davidnind.com> --- The tests also fail for me - latest main, latest KTD (default, no changes to default setting): prove t/db_dependent/Circulation.t t/db_dependent/Holds/ExpireReservesAutoFill.t t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t t/db_dependent/Reserves/MultiplePerRecord.t t/db_dependent/ILSDI_Services.t t/db_dependent/Hold.t t/db_dependent/Reports/Guided.t t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Items.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation.t ..................... 31/87 # Transfer limit: Holding -> Return # Transfer limit: Return -> Home # Transfer limit: Return -> Holding t/db_dependent/Circulation.t ..................... ok t/db_dependent/Holds/ExpireReservesAutoFill.t .... ok t/db_dependent/Holds/WaitingReserves.t ........... ok t/db_dependent/Reserves/CancelExpiredReserves.t .. ok t/db_dependent/Reserves/MultiplePerRecord.t ...... ok t/db_dependent/ILSDI_Services.t .................. 4/16 # Failed test 'Too many reserves' # at t/db_dependent/ILSDI_Services.t line 531. # got: 'tooManyReservesToday' # expected: 'tooManyReserves' # Failed test 'No reserves allowed' # at t/db_dependent/ILSDI_Services.t line 549. # got: 'tooManyReservesToday' # expected: 'noReservesAllowed' # Looks like you failed 2 tests of 9. t/db_dependent/ILSDI_Services.t .................. 6/16 # Failed test 'Holds test' # at t/db_dependent/ILSDI_Services.t line 650. t/db_dependent/ILSDI_Services.t .................. 15/16 # Looks like you failed 1 test of 16. t/db_dependent/ILSDI_Services.t .................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/16 subtests t/db_dependent/Hold.t ............................ ok t/db_dependent/Reports/Guided.t .................. ok t/db_dependent/api/v1/holds.t .................... 10/20 # Failed test 'Override works for 'hold_limit'' # at t/db_dependent/api/v1/holds.t line 1033. # got: '403' # expected: '201' # Looks like you planned 7 tests but ran 5. # Looks like you failed 1 test of 5 run. # Failed test ''hold_limit' tests' # at t/db_dependent/api/v1/holds.t line 1041. # Looks like you planned 7 tests but ran 6. # Looks like you failed 1 test of 6 run. t/db_dependent/api/v1/holds.t .................... 11/20 # Failed test 'add() + can_place_holds() tests' # at t/db_dependent/api/v1/holds.t line 1083. Can't call method "delete" on an undefined value at t/db_dependent/api/v1/holds.t line 1035. # Looks like your test exited with 11 just after 12. t/db_dependent/api/v1/holds.t .................... Dubious, test returned 11 (wstat 2816, 0xb00) Failed 9/20 subtests t/db_dependent/api/v1/checkouts.t ................ ok t/db_dependent/Koha/Items.t ...................... ok t/db_dependent/HoldsQueue.t ...................... ok Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 256 (exited 1) Tests: 16 Failed: 1) Failed test: 6 Non-zero exit status: 1 t/db_dependent/api/v1/holds.t (Wstat: 2816 (exited 11) Tests: 12 Failed: 1) Failed test: 11 Non-zero exit status: 11 Parse errors: Bad plan. You planned 20 tests but ran 12. Files=12, Tests=411, 129 wallclock secs ( 0.29 usr 0.04 sys + 93.23 cusr 21.68 csys = 115.24 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I can replicate David's errors in t/db_dependent/ILSDI_Services.t and t/db_dependent/api/v1/holds.t when there's a value in Holds Allowed (daily). Both tests fail with this code applied and a value in that circ rule. I've got a couple other tests in that list that currently fail with our without these patches. t/db_dependent/Circulation.t fails with "# Failed test 'No tests run for subtest "Test CanBookBeIssued param ignore_reserves (Bug 35322)"' # at t/db_dependent/Circulation.t line 7887. encountered object '2026-06-15T15:48:49', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /usr/share/perl5/JSON.pm line 173." t/db_dependent/Hold.t gives the following if the Holds Log is enabled: "t/db_dependent/Hold.t .. 1/36 cannot encode reference to scalar 'SCALAR(0xaaab22007568)' unless the scalar is 0 or 1 at /kohadevbox/koha/C4/Log.pm line 166." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The only failure I get is /kohadevbox/koha/t/db_dependent/Holds.t and that fails with or without this patchset when I give 'Holds allowed (daily)' a value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm kicking this back to Signed Off. I've filed bug 43071 for the failing tests when Holds Allowed (daily) has a value, as those errors are consistent with and without this code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43071 [Bug 43071] Test failures when Holds Allowed (daily) has a value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199275|0 |1 is obsolete| | Attachment #199276|0 |1 is obsolete| | Attachment #199306|0 |1 is obsolete| | Attachment #199308|0 |1 is obsolete| | Attachment #199309|0 |1 is obsolete| | Attachment #199310|0 |1 is obsolete| | Attachment #199313|0 |1 is obsolete| | Attachment #199323|0 |1 is obsolete| | Attachment #199324|0 |1 is obsolete| | Attachment #199326|0 |1 is obsolete| | Attachment #200542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202323&action=edit Bug 42558: DBIC update [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202325&action=edit Bug 42558: Update today_holds_count to account for datetime Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202327&action=edit Bug 42558: Update t/db_dependent/Holds.t to compare only date portion Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202329&action=edit Bug 42558: Fix reservedate comparisons in t/db_dependent/api/v1/holds.t Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202331&action=edit Bug 42558: Fix for date comparisons Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43071 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43071 [Bug 43071] Test failures when Holds Allowed (daily) has a value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #48 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, a few blockers here worth revisiting: Finding 1: 'Holds to pull' drops holds placed today 1) Apply the patches, updatedatabase and restart_all 2) Place a hold on biblio 4 for patron cardnumber '42', no dates, pickup at Centerville: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=4 3) Go to Circulation > Holds to pull: http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl => Expected: the hold from 2) is listed => Actual: it's missing Finding 2: filtering the REST API by hold date fails 1) Query holds placed since 2020, as the API spec documents it (format: date): curl -s -u koha:koha -G http://localhost:8081/api/v1/holds --data-urlencode 'q={"hold_date":{">=":"2020-01-01"}}' => Expected: a list of holds => Actual: {"error_code":"bad_parameter", ...} 2) Same query with a full date-time instead: curl -s -u koha:koha -G http://localhost:8081/api/v1/holds --data-urlencode 'q={"hold_date":{">=":"2020-01-01T00:00:00+00:00"}}' => This one returns the holds, so only the date-only form documented in the spec fails Finding 3: 'Holds statistics' breaks on hold dates 1) Place a hold on biblio 1 for patron cardnumber '42', no dates, pickup at Centerville, a minute after the one from Finding 1: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) Go to Reports > Holds statistics: http://localhost:8081/cgi-bin/koha/reports/reserves_stats.pl 3) On the 'Hold date' line, click the radio button under 'Row' (leave 'Column' on 'Hold status'). Click 'Submit' at the bottom => Expected: one row for today, counting both holds => Actual: one row per hold, each labelled with its own time 4) Go back, and on the 'Hold date' line set 'From' to yesterday and 'To' to today. Submit => Expected: today's holds are counted => Actual: they're gone Finding 4: 'Hold ratios' drops holds on the chosen end date 1) Go to Circulation > Hold ratios (biblio 1 has a single item, so the hold from Finding 3 gives it a ratio of 1): http://localhost:8081/cgi-bin/koha/circ/reserveratios.pl 2) Set 'Hold ratio' to 1 and 'End date' to today. Submit => Expected: biblio 1 is listed (1 hold, 1 item) => Actual: it's missing 3) Set 'End date' to tomorrow and submit again => It now shows -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202322|0 |1 is obsolete| | Attachment #202323|0 |1 is obsolete| | Attachment #202325|0 |1 is obsolete| | Attachment #202326|0 |1 is obsolete| | Attachment #202327|0 |1 is obsolete| | Attachment #202328|0 |1 is obsolete| | Attachment #202329|0 |1 is obsolete| | Attachment #202330|0 |1 is obsolete| | Attachment #202331|0 |1 is obsolete| | Attachment #202332|0 |1 is obsolete| | Attachment #206992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207035&action=edit Bug 42558: DBIC update [DO NOT PUSH] Patch from commit d454bbe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207037&action=edit Bug 42558: Use format_datetime in current_holds sub, instead of format_date Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207039&action=edit Bug 42558: Fix Reserve.t tests by updating reservedate calculations Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207041&action=edit Bug 42558: Fix test comparisons in t/db_dependent/ILSDI_Services.t Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207043&action=edit Bug 42558: Use dt_from_string on reservedate in Circulation.pm Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207045&action=edit Bug 42558: Adjust API defs and path to date-time Patch from commit 0c5f18d -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207048&action=edit Bug 42558: Update opac-reserve.pl and placerequest.pl Patch from commit 7cfc9c4 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I originally wrote this as prep work for Bug 42524 but we've decided to go forward with reserve id there. Besides Bug 42524, Im not sure if there is any interest in converting reservedate to date-time. I'll leave my patches here as is, if anyone else is interested in continuing this work. -- You are receiving this mail because: You are watching all bug changes.