[Bug 42558] New: reserves.reservedate should be datetime instead of date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Bug ID: 42558 Summary: reserves.reservedate should be datetime instead of date Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In front of work I intend to do on Bug 42524. In order to calculate priorities based on reservedate, the reservedate must include time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 [Bug 42524] Option to calculate priorities based on reservedate when moving hold to a new record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looking at kohastructure.sql it will need to be changed for reserves, old_reserves, and tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198791&action=edit Bug 42558: Database updates Patch from commit d550ec2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198792&action=edit Bug 42558: DBIC update [DO NOT PUSH] Patch from commit 245dfa8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199268&action=edit Bug 42558: Database updates Patch from commit dc99ff2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199269&action=edit Bug 42558: DBIC update [DO NOT PUSH] Patch from commit 15a2b6d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199270&action=edit Bug 42558: Ensure API returns hold_date as just a date Patch from commit fdde37c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199272&action=edit Bug 42558: Database updates Patch from commit dc99ff2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199273&action=edit Bug 42558: DBIC update [DO NOT PUSH] Patch from commit 15a2b6d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199274&action=edit Bug 42558: Ensure API returns hold_date as just a date To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 199275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199275&action=edit Bug 42558: Database updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 199276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199276&action=edit Bug 42558: DBIC update [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 199277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199277&action=edit Bug 42558: Ensure API returns hold_date as just a date To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks for the quick sign-off here David! I did realize there is more to do! Many tests are now failing with this bug applied. Setting back to ASSIGNED. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- As is I can place holds and exceed my daily limit: 1. APPLY PATCH, updatedatabase, restart_all 2. Administration > Circulation and fine rules, set Holds Allowed ( Daily ) to 1. 3. Notice you can place more than 1 hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199306&action=edit Bug 42558: Ensure API returns hold_date as just a date To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199307&action=edit Bug 42558: Update today_holds_count to account for datetime Patch from commit 56afcf4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199308&action=edit Bug 42558: Update today_holds_count to account for datetime Patch from commit 56afcf4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199309&action=edit Bug 42558: Use format_datetime in current_holds sub, instead of format_date Patch from commit 56ac1d1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199310&action=edit Bug 42558: Update t/db_dependent/Holds.t to compare only date portion Patch from commit b003ce3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199313&action=edit Bug 42558: Fix Reserve.t tests by updating reservedate calculations Patch from commit 8643b32 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199323&action=edit Bug 42558: Fix reservedate comparisons in t/db_dependent/api/v1/holds.t Patch from commit 96ecf56 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199324&action=edit Bug 42558: Fix test comparisons in t/db_dependent/ILSDI_Services.t Patch from commit 5df6606 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199326&action=edit Bug 42558: Fix for date comparisons Patch from commit a35b5d7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. 5. Administration > Circulation and fine rules, set Holds Allowed ( Daily ) to 1. 6. Try to place additional holds, make sure the daily limits are respected. prove t/db_dependent/Circulation.t t/db_dependent/Holds/ExpireReservesAutoFill.t t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t t/db_dependent/Reserves/MultiplePerRecord.t t/db_dependent/ILSDI_Services.t t/db_dependent/Hold.t t/db_dependent/Reports/Guided.t t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Items.t t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.mathevet@inLibro.com --- Comment #25 from Chris Mathevet <chris.mathevet@inLibro.com> --- Everything works except the tests Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 512 (exited 2) Tests: 16 Failed: 2) Failed tests: 6, 16 Non-zero exit status: 2 t/db_dependent/api/v1/holds.t (Wstat: 24320 (exited 95) Tests: 12 Failed: 2) Failed tests: 11-12 Non-zero exit status: 95 Parse errors: Bad plan. You planned 20 tests but ran 12. t/db_dependent/HoldsQueue.t (Wstat: 24320 (exited 95) Tests: 49 Failed: 1) Failed test: 48 Non-zero exit status: 95 Parse errors: Bad plan. You planned 65 tests but ran 49. Files=12, Tests=395, 150 wallclock secs ( 0.23 usr 0.05 sys + 113.28 cusr 15.07 csys = 128.63 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chris Mathevet from comment #25)
Everything works except the tests
Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 512 (exited 2) Tests: 16 Failed: 2) Failed tests: 6, 16 Non-zero exit status: 2 t/db_dependent/api/v1/holds.t (Wstat: 24320 (exited 95) Tests: 12 Failed: 2) Failed tests: 11-12 Non-zero exit status: 95 Parse errors: Bad plan. You planned 20 tests but ran 12. t/db_dependent/HoldsQueue.t (Wstat: 24320 (exited 95) Tests: 49 Failed: 1) Failed test: 48 Non-zero exit status: 95 Parse errors: Bad plan. You planned 65 tests but ran 49. Files=12, Tests=395, 150 wallclock secs ( 0.23 usr 0.05 sys + 113.28 cusr 15.07 csys = 128.63 CPU) Result: FAIL
Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services? I cannot recreate these failures and all tests pass for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #27 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 199517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199517&action=edit Failed test output (In reply to Lucas Gass (lukeg) from comment #26)
(In reply to Chris Mathevet from comment #25)
Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services?
I cannot recreate these failures and all tests pass for me.
Hey, I did update the database and run yarn build. What do you mean by "restarting all services", do you use any special environment to test ? I rebooted my computer but still got the same result. Here is the prove output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chris Mathevet from comment #27)
Created attachment 199517 [details] Failed test output
(In reply to Lucas Gass (lukeg) from comment #26)
(In reply to Chris Mathevet from comment #25)
Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services?
I cannot recreate these failures and all tests pass for me.
Hey, I did update the database and run yarn build. What do you mean by "restarting all services", do you use any special environment to test ? I rebooted my computer but still got the same result.
Here is the prove output.
I test in koha-testing-docker, I still cannot recreate any of the failures you describe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #28)
(In reply to Chris Mathevet from comment #27)
Created attachment 199517 [details] Failed test output
(In reply to Lucas Gass (lukeg) from comment #26)
(In reply to Chris Mathevet from comment #25)
Hey Chris, thanks for testing! Can you confirm that you are running the database update, running yarn build, and restarting all services?
I cannot recreate these failures and all tests pass for me.
Hey, I did update the database and run yarn build. What do you mean by "restarting all services", do you use any special environment to test ? I rebooted my computer but still got the same result.
Here is the prove output.
I test in koha-testing-docker, I still cannot recreate any of the failures you describe.
I had some colleagues give this a try and no ones able to recreate this. I am resetting to 'Needs Signoff' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #30 from David Nind <david@davidnind.com> --- The tests also fail for me - latest main, latest KTD (default, no changes to default setting): prove t/db_dependent/Circulation.t t/db_dependent/Holds/ExpireReservesAutoFill.t t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t t/db_dependent/Reserves/MultiplePerRecord.t t/db_dependent/ILSDI_Services.t t/db_dependent/Hold.t t/db_dependent/Reports/Guided.t t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Items.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation.t ..................... 31/87 # Transfer limit: Holding -> Return # Transfer limit: Return -> Home # Transfer limit: Return -> Holding t/db_dependent/Circulation.t ..................... ok t/db_dependent/Holds/ExpireReservesAutoFill.t .... ok t/db_dependent/Holds/WaitingReserves.t ........... ok t/db_dependent/Reserves/CancelExpiredReserves.t .. ok t/db_dependent/Reserves/MultiplePerRecord.t ...... ok t/db_dependent/ILSDI_Services.t .................. 4/16 # Failed test 'Too many reserves' # at t/db_dependent/ILSDI_Services.t line 531. # got: 'tooManyReservesToday' # expected: 'tooManyReserves' # Failed test 'No reserves allowed' # at t/db_dependent/ILSDI_Services.t line 549. # got: 'tooManyReservesToday' # expected: 'noReservesAllowed' # Looks like you failed 2 tests of 9. t/db_dependent/ILSDI_Services.t .................. 6/16 # Failed test 'Holds test' # at t/db_dependent/ILSDI_Services.t line 650. t/db_dependent/ILSDI_Services.t .................. 15/16 # Looks like you failed 1 test of 16. t/db_dependent/ILSDI_Services.t .................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/16 subtests t/db_dependent/Hold.t ............................ ok t/db_dependent/Reports/Guided.t .................. ok t/db_dependent/api/v1/holds.t .................... 10/20 # Failed test 'Override works for 'hold_limit'' # at t/db_dependent/api/v1/holds.t line 1033. # got: '403' # expected: '201' # Looks like you planned 7 tests but ran 5. # Looks like you failed 1 test of 5 run. # Failed test ''hold_limit' tests' # at t/db_dependent/api/v1/holds.t line 1041. # Looks like you planned 7 tests but ran 6. # Looks like you failed 1 test of 6 run. t/db_dependent/api/v1/holds.t .................... 11/20 # Failed test 'add() + can_place_holds() tests' # at t/db_dependent/api/v1/holds.t line 1083. Can't call method "delete" on an undefined value at t/db_dependent/api/v1/holds.t line 1035. # Looks like your test exited with 11 just after 12. t/db_dependent/api/v1/holds.t .................... Dubious, test returned 11 (wstat 2816, 0xb00) Failed 9/20 subtests t/db_dependent/api/v1/checkouts.t ................ ok t/db_dependent/Koha/Items.t ...................... ok t/db_dependent/HoldsQueue.t ...................... ok Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 256 (exited 1) Tests: 16 Failed: 1) Failed test: 6 Non-zero exit status: 1 t/db_dependent/api/v1/holds.t (Wstat: 2816 (exited 11) Tests: 12 Failed: 1) Failed test: 11 Non-zero exit status: 11 Parse errors: Bad plan. You planned 20 tests but ran 12. Files=12, Tests=411, 129 wallclock secs ( 0.29 usr 0.04 sys + 93.23 cusr 21.68 csys = 115.24 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #31 from David Nind <david@davidnind.com> --- Note: Tests all pass if I change "Holds allowed (daily)" back to empty, if it is set to 1 (previous steps in the test plan) the tests fail. prove t/db_dependent/Circulation.t t/db_dependent/Holds/ExpireReservesAutoFill.t t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t t/db_dependent/Reserves/MultiplePerRecord.t t/db_dependent/ILSDI_Services.t t/db_dependent/Hold.t t/db_dependent/Reports/Guided.t t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Items.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation.t ..................... 31/87 # Transfer limit: Holding -> Return # Transfer limit: Return -> Home # Transfer limit: Return -> Holding t/db_dependent/Circulation.t ..................... ok t/db_dependent/Holds/ExpireReservesAutoFill.t .... ok t/db_dependent/Holds/WaitingReserves.t ........... ok t/db_dependent/Reserves/CancelExpiredReserves.t .. ok t/db_dependent/Reserves/MultiplePerRecord.t ...... ok t/db_dependent/ILSDI_Services.t .................. ok t/db_dependent/Hold.t ............................ ok t/db_dependent/Reports/Guided.t .................. ok t/db_dependent/api/v1/holds.t .................... ok t/db_dependent/api/v1/checkouts.t ................ ok t/db_dependent/Koha/Items.t ...................... ok t/db_dependent/HoldsQueue.t ...................... ok All tests successful. Files=12, Tests=419, 141 wallclock secs ( 0.33 usr 0.03 sys + 101.57 cusr 24.00 csys = 125.93 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I can replicate David's errors in t/db_dependent/ILSDI_Services.t and t/db_dependent/api/v1/holds.t when there's a value in Holds Allowed (daily). Both tests fail with this code applied and a value in that circ rule. I've got a couple other tests in that list that currently fail with our without these patches. t/db_dependent/Circulation.t fails with "# Failed test 'No tests run for subtest "Test CanBookBeIssued param ignore_reserves (Bug 35322)"' # at t/db_dependent/Circulation.t line 7887. encountered object '2026-06-15T15:48:49', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /usr/share/perl5/JSON.pm line 173." t/db_dependent/Hold.t gives the following if the Holds Log is enabled: "t/db_dependent/Hold.t .. 1/36 cannot encode reference to scalar 'SCALAR(0xaaab22007568)' unless the scalar is 0 or 1 at /kohadevbox/koha/C4/Log.pm line 166." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200542&action=edit Bug 42558: Use dt_from_string on reservedate in Circulation.pm Patch from commit 130f70d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The only failure I get is /kohadevbox/koha/t/db_dependent/Holds.t and that fails with or without this patchset when I give 'Holds allowed (daily)' a value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43071 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm kicking this back to Signed Off. I've filed bug 43071 for the failing tests when Holds Allowed (daily) has a value, as those errors are consistent with and without this code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43071 [Bug 43071] Test failures when Holds Allowed (daily) has a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199275|0 |1 is obsolete| | Attachment #199276|0 |1 is obsolete| | Attachment #199306|0 |1 is obsolete| | Attachment #199308|0 |1 is obsolete| | Attachment #199309|0 |1 is obsolete| | Attachment #199310|0 |1 is obsolete| | Attachment #199313|0 |1 is obsolete| | Attachment #199323|0 |1 is obsolete| | Attachment #199324|0 |1 is obsolete| | Attachment #199326|0 |1 is obsolete| | Attachment #200542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202322&action=edit Bug 42558: Database updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202323&action=edit Bug 42558: DBIC update [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202324&action=edit Bug 42558: Ensure API returns hold_date as just a date To test: 1. APPLY PATCH, updatedatabase, yarn_build, restart_all 2. Place a hold on something, ensuring everything works. 3. sudo koha-mysql kohadev: SELECT reservedate FROM reserves; 4. See that the reservedate should include a timestamp. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202325&action=edit Bug 42558: Update today_holds_count to account for datetime Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202326&action=edit Bug 42558: Use format_datetime in current_holds sub, instead of format_date Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202327&action=edit Bug 42558: Update t/db_dependent/Holds.t to compare only date portion Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202328&action=edit Bug 42558: Fix Reserve.t tests by updating reservedate calculations Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202329&action=edit Bug 42558: Fix reservedate comparisons in t/db_dependent/api/v1/holds.t Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202330&action=edit Bug 42558: Fix test comparisons in t/db_dependent/ILSDI_Services.t Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202331&action=edit Bug 42558: Fix for date comparisons Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 202332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202332&action=edit Bug 42558: Use dt_from_string on reservedate in Circulation.pm Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43071 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43071 [Bug 43071] Test failures when Holds Allowed (daily) has a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Failing tests are fixed now in the related bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org