https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #48 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, a few blockers here worth revisiting: Finding 1: 'Holds to pull' drops holds placed today 1) Apply the patches, updatedatabase and restart_all 2) Place a hold on biblio 4 for patron cardnumber '42', no dates, pickup at Centerville: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=4 3) Go to Circulation > Holds to pull: http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl => Expected: the hold from 2) is listed => Actual: it's missing Finding 2: filtering the REST API by hold date fails 1) Query holds placed since 2020, as the API spec documents it (format: date): curl -s -u koha:koha -G http://localhost:8081/api/v1/holds --data-urlencode 'q={"hold_date":{">=":"2020-01-01"}}' => Expected: a list of holds => Actual: {"error_code":"bad_parameter", ...} 2) Same query with a full date-time instead: curl -s -u koha:koha -G http://localhost:8081/api/v1/holds --data-urlencode 'q={"hold_date":{">=":"2020-01-01T00:00:00+00:00"}}' => This one returns the holds, so only the date-only form documented in the spec fails Finding 3: 'Holds statistics' breaks on hold dates 1) Place a hold on biblio 1 for patron cardnumber '42', no dates, pickup at Centerville, a minute after the one from Finding 1: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=1 2) Go to Reports > Holds statistics: http://localhost:8081/cgi-bin/koha/reports/reserves_stats.pl 3) On the 'Hold date' line, click the radio button under 'Row' (leave 'Column' on 'Hold status'). Click 'Submit' at the bottom => Expected: one row for today, counting both holds => Actual: one row per hold, each labelled with its own time 4) Go back, and on the 'Hold date' line set 'From' to yesterday and 'To' to today. Submit => Expected: today's holds are counted => Actual: they're gone Finding 4: 'Hold ratios' drops holds on the chosen end date 1) Go to Circulation > Hold ratios (biblio 1 has a single item, so the hold from Finding 3 gives it a ratio of 1): http://localhost:8081/cgi-bin/koha/circ/reserveratios.pl 2) Set 'Hold ratio' to 1 and 'End date' to today. Submit => Expected: biblio 1 is listed (1 hold, 1 item) => Actual: it's missing 3) Set 'End date' to tomorrow and submit again => It now shows -- You are receiving this mail because: You are watching all bug changes.