[Bug 21307] New: Switch two-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Bug ID: 21307 Summary: Switch two-column templates to Bootstrap grid: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 20044 There are two two-column cataloging templates which can be updated to use the Bootstrap grid. - cataloguing\editor.tt - cataloguing\additem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20044 | Blocks| |20654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78358&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78358|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 78428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78428&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A scrollbar appears and the "status bar" is no longer displayed at the bottom of the screen (it is displayed but at the bottom of the page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78428|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86085&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86086&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86085 Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging Review of attachment 86085: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21307&attachment=86085) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +378,5 @@
+ </div> <!-- /.col-sm-10.col-sm-push-2 --> + + <div class="col-sm-2 col-sm-pull-10"> + <aside> + [% INCLUDE 'admin-menu.inc' %]
This should be deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86109&action=edit Rancor glitch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86085|0 |1 is obsolete| | Attachment #86086|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86462&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86463&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86464&action=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86462|0 |1 is obsolete| | Attachment #86463|0 |1 is obsolete| | Attachment #86464|0 |1 is obsolete| | --- Comment #11 from Michal Denar <black23@gmail.com> --- Created attachment 87949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87949&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #12 from Michal Denar <black23@gmail.com> --- Created attachment 87950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87950&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #13 from Michal Denar <black23@gmail.com> --- Created attachment 87951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87951&action=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87949|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88134&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87950|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88135&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87951|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88136&action=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enahancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org