[Bug 22584] New: Add YAML support for Codemirror
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Bug ID: 22584 Summary: Add YAML support for Codemirror Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- It would be great if YAML syntax support was available as we use it in a couple places, specially in plugin configurations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I have a patch ready to add support for YAML syntax, but should I also add a patch with an example implementation? If so, what is a good candidate? Are there system preferences which expect YAML? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21582 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- OpacHiddenItems is a candidate. The CSV2MARC plugin configuration too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21582 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21582 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 [Bug 21582] Use CodeMirror for *UserJS & *UserCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87279&action=edit Bug 22584: Add YAML support for Codemirror This patch adds the dependencies required to provide YAML syntax highlighting in CodeMirror text areas. The OpacHiddenItems system preference configuration is updated to use a "text/x-yaml" CodeMirror syntax. To test, apply the patch and go to Administration -> System preferences -> OPAC. Expand the OpacHiddenItems preference and test that YAML-formatted text entry has the correct syntax highlighting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87279|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23@gmail.com> --- Created attachment 87944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87944&action=edit Bug 22584: Add YAML support for Codemirror This patch adds the dependencies required to provide YAML syntax highlighting in CodeMirror text areas. The OpacHiddenItems system preference configuration is updated to use a "text/x-yaml" CodeMirror syntax. To test, apply the patch and go to Administration -> System preferences -> OPAC. Expand the OpacHiddenItems preference and test that YAML-formatted text entry has the correct syntax highlighting. Signed-off-by: Michal Denar <black23@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=2700 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87944|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88133&action=edit Bug 22584: Add YAML support for Codemirror This patch adds the dependencies required to provide YAML syntax highlighting in CodeMirror text areas. The OpacHiddenItems system preference configuration is updated to use a "text/x-yaml" CodeMirror syntax. To test, apply the patch and go to Administration -> System preferences -> OPAC. Expand the OpacHiddenItems preference and test that YAML-formatted text entry has the correct syntax highlighting. Signed-off-by: Michal Denar <black23@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=2700 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Bug 22584 depends on bug 21582, which changed state. Bug 21582 Summary: Use CodeMirror for *UserJS & *UserCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org