[Bug 13368] New: Checking out an item not on loan, but with a hold, busts the holds priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Bug ID: 13368 Summary: Checking out an item not on loan, but with a hold, busts the holds priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you place 3 holds on an item that is not on loan. Then check that item out to the person who is second in the queue, the holds are not reordered. They will be 1 and 3. This is because ModReserveFill deletes the hold from the reserves table, after putting it in the oldreserves table. It then passes the reserve id to _FixPriority. _FixPriority then queries the reserves table, and suprise suprise can't find the hold, and nothing is reordered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34051&action=edit Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34051|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34064&action=edit [SIGNED-OFF] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed the problem without the patch, and confirmed that the patch corrects it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34064|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34148&action=edit [PASSED QA] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed the problem without the patch, and confirmed that the patch corrects it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org