[Bug 13355] New: System preferences tab value wrong in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Bug ID: 13355 Summary: System preferences tab value wrong in templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)"> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33993&action=edit Bug 13355: System preferences tab value wrong in templates This patch fixes a bug on the system preferences tab templates. To test: To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)"> - Apply the patch - Repeat (1) and (2) => SUCCESS: you will see below the form tag something like: <input type="hidden" name="tab" value="enhanced_content"> and <input type="hidden" name="tab" value="opac"> respectively. - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #2 from wajasu <matted-34813@mypacks.net> --- Created attachment 34005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34005&action=edit [SIGNED-OFF] Bug 13355 System preferences tab value wrong in template Used view source to inspect before and after patch. It works! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|0 |1 is obsolete| | --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Created attachment 34006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34006&action=edit [SIGNED-OFF] Bug 13355: System preferences tab value wrong in templates Patched worked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34006|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34149&action=edit [PASSED QA] Bug 13355: System preferences tab value wrong in templates This patch fixes a bug on the system preferences tab templates. To test: To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)"> - Apply the patch - Repeat (1) and (2) => SUCCESS: you will see below the form tag something like: <input type="hidden" name="tab" value="enhanced_content"> and <input type="hidden" name="tab" value="opac"> respectively. - Sign off :-D Regards Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org