[Bug 33891] New: Use template wrapper for tabs: OPAC advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Bug ID: 33891 Summary: Use template wrapper for tabs: OPAC advanced search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the OPAC advanced search page use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151988&action=edit Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33892 [Bug 33892] Use template wrapper for tabs: OPAC authority detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Bug 33891 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32571 | Blocks| |32571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33893 [Bug 33893] Use template wrapper for tabs: OPAC checkout history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 [Bug 33894] Use template wrapper for tabs: OPAC search history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 [Bug 33895] Use template wrapper for tabs: OPAC user summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151988|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152015&action=edit Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152015|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 152032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152032&action=edit Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org