[Bug 33883] New: "Make sure to copy your API secret" message overlaps text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Bug ID: 33883 Summary: "Make sure to copy your API secret" message overlaps text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org After you generate an API key for a patron, the grey border around the message "Make sure to copy your API secret now. You won’t be able to see it again!" overlaps the "Description: " text below it. It's hard to see but it does look bad when you notice it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33875 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151982&action=edit Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Depends on| |33875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 [Bug 33875] Missing closing tag a in API key management page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151982|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151983&action=edit Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151983|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151985&action=edit Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151985|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 152033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152033&action=edit Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org