[Bug 32182] New: Replace static tabs markup with Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Bug ID: 32182 Summary: Replace static tabs markup with Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: david@davidnind.com, dcook@prosentient.com.au, gmcharlt@gmail.com, lucas@bywatersolutions.com, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org Depends on: 30952 In order for tabs to look correct on certain pages which use the "statictabs" class we need to restructure the tabs to use Bootstrap markup. maininvoice.tt pay.tt paycollect.tt reviewswaiting.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31759 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 [Bug 31759] Improve styling of tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30952 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143830&action=edit Bug 32182: Replace static tabs markup with Bootstrap This patch reimplements certain tabbed interfaces to use Bootstrap markup. Previously these tabs required special CSS because they're static, i.e. not JS-driven tabs for switching in-page. The tabs are links to separate pages. Note: This patch includes whitespace changes, so use diff accordingly. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the tabs look correct and still link to the correct locations: - Patron details - Accounting - Pay amount - Transactions - Create manual invoice - Create manual credit - Tools -> Comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(.. git bz apply 32182 Bug 32182 - Replace static tabs markup with Bootstrap 143830 - Bug 32182: Replace static tabs markup with Bootstrap Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32182: Replace static tabs markup with Bootstrap Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32182: Replace static tabs markup with Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143830|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143832&action=edit Bug 32103: Remove flex from tab-content list elements Bug 32182: Replace static tabs markup with Bootstrap This patch reimplements certain tabbed interfaces to use Bootstrap markup. Previously these tabs required special CSS because they're static, i.e. not JS-driven tabs for switching in-page. The tabs are links to separate pages. Note: This patch includes whitespace changes, so use diff accordingly. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the tabs look correct and still link to the correct locations: - Patron details - Accounting - Pay amount - Transactions - Create manual invoice - Create manual credit - Tools -> Comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143833&action=edit Bug 32182: Replace static tabs markup with Bootstrap This patch reimplements certain tabbed interfaces to use Bootstrap markup. Previously these tabs required special CSS because they're static, i.e. not JS-driven tabs for switching in-page. The tabs are links to separate pages. Note: This patch includes whitespace changes, so use diff accordingly. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the tabs look correct and still link to the correct locations: - Patron details - Accounting - Pay amount - Transactions - Create manual invoice - Create manual credit - Tools -> Comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143833|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 143836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143836&action=edit Bug 32182: Replace static tabs markup with Bootstrap This patch reimplements certain tabbed interfaces to use Bootstrap markup. Previously these tabs required special CSS because they're static, i.e. not JS-driven tabs for switching in-page. The tabs are links to separate pages. Note: This patch includes whitespace changes, so use diff accordingly. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the tabs look correct and still link to the correct locations: - Patron details - Accounting - Pay amount - Transactions - Create manual invoice - Create manual credit - Tools -> Comments Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143836|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143865&action=edit Bug 32182: Replace static tabs markup with Bootstrap This patch reimplements certain tabbed interfaces to use Bootstrap markup. Previously these tabs required special CSS because they're static, i.e. not JS-driven tabs for switching in-page. The tabs are links to separate pages. Note: This patch includes whitespace changes, so use diff accordingly. To test, apply the patch and rebuild the staff interface CSS. Test the following pages to confirm that the tabs look correct and still link to the correct locations: - Patron details - Accounting - Pay amount - Transactions - Create manual invoice - Create manual credit - Tools -> Comments Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182 Bug 32182 depends on bug 31759, which changed state. Bug 31759 Summary: Improve styling of tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org