[Bug 9216] New: Add a file for table headings translation and copy of this file during the translation process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bug ID: 9216 Summary: Add a file for table headings translation and copy of this file during the translation process Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com Headings of table are defined in columns.def file, but only in english. French libraries want them in french. This patch adds a columns.def.fr-FR file and copies this file into the fr-FR directory tree during the translation process. columns.def.{lang} can be added as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 13895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13895&action=edit Bug 9216 : adding columns.def.fr-FR for table headings translation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 13896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13896&action=edit Bug 9216 : Adding copy of columns.def.{lang} (if it exists) into {lang} directory tree during translation process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Would it not be better to fold columns.def into the normal translation process, i.e., so that translators can supply or update a PO file for which language-specific columns.def.lang files can be generated? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)
Would it not be better to fold columns.def into the normal translation process
This sounds sensible to me, but I say that without knowing how hard it would be to accomplish. Perhaps someone who knows could comment? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13895|0 |1 is obsolete| | Attachment #13896|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22521&action=edit Bug 9216: columns.def file is not translatable The sql column headers is stored into the columns.def file. This file is not managed by the translation script. This patch makes possible the headers translation. Note: The translation xml tags were added to avoid all lines to be put on a single line. Test plan: 1/ update your po file cd misc/translate; perl translate -f columns update LANG # Replace by another language here 2/ translate header columns (search "columns.def" in your po file). Be careful, you have to keep the column names! 3/ install the translated columns.def perl translate -f columns install LANG # Replace by another language here 4/ go on the report module > create a new report > next > next 5/ change the language on the 3rd step, you should see the column header translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #3)
Would it not be better to fold columns.def into the normal translation process, i.e., so that translators can supply or update a PO file for which language-specific columns.def.lang files can be generated?
It is what I do in this last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a file for table |Make table headings |headings translation and |translatable |copy of this file during | |the translation process | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Jonathan, it works, but there is a small conflict on applying the patch, columns.def may have changed Anyway, may I suggest using instead of <translation>biblioitems.volumedesc: Volume information</translation> something like <table name="biblioitems.volumedesc:">Volume information</table> I think it's equally easier to match and split. And as a bonus column names remain untouched and some strings can have translations. In the first case, we have on PO file msgid "biblioitems.volumedesc: Volume information" in the second msgid "Volume information" which is better to translate Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22521|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26989&action=edit Bug 9216: columns.def file is not translatable The sql column headers is stored into the columns.def file. This file is not managed by the translation script. This patch makes possible the headers translation. Note: The translation xml tags were added to avoid all lines to be put on a single line. Test plan: 1/ update your po file cd misc/translate; perl translate -f columns update LANG # Replace by another language here 2/ translate header columns (search "columns.def" in your po file). 3/ install the translated columns.def perl translate -f columns install LANG # Replace by another language here 4/ go on the report module > create a new report > next > next 5/ change the language on the 3rd step, you should see the column header translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #7)
Anyway, may I suggest using instead of <translation>biblioitems.volumedesc: Volume information</translation> something like <table name="biblioitems.volumedesc:">Volume information</table> I think it's equally easier to match and split.
Very good idea! I did that in the new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26989|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27007&action=edit [SIGNED-OFF] Bug 9216: columns.def file is not translatable The sql column headers is stored into the columns.def file. This file is not managed by the translation script. This patch makes possible the headers translation. Note: The translation xml tags were added to avoid all lines to be put on a single line. Test plan: 1/ update your po file cd misc/translate; perl translate -f columns update LANG # Replace by another language here 2/ translate header columns (search "columns.def" in your po file). 3/ install the translated columns.def perl translate -f columns install LANG # Replace by another language here 4/ go on the report module > create a new report > next > next 5/ change the language on the 3rd step, you should see the column header translated. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors [on es-ES about a third of the strings translated!! :-) ] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Almost an xml file now... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like that someone is fixing this long standing bug! I think it Could be easier to translate the columns correctly, if we had the the original column in the translation string as well. Or maybe as a note? Still, this is a big improvement and works nicely :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27007|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27308&action=edit 0001-PASSED-QA-Bug-9216-columns.def-file-is-not-translata.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27309&action=edit 0002-Bug-9216-Make-description-in-columns.def-more-specif.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org