http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 25978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25978&action=edit Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4833 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25978|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 26037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26037&action=edit Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26037|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26525&action=edit [PASSED QA] Bug 11914 - Ordering from suggestions: fund (budget id) is not retained; price calculations not working When order is being created from purchase suggestion: - Budget/fund stored in suggestion record (if any) is not retained on order page, system always defaults to 'Select a fund' even if some fund was already chosen for a suggestion on the earlier stage. - If there was a price given to, and stored within suggestion record, initial prices calculations on order page are not working properly ('Replacement cost', 'Budgeted cost' and 'Total' show as 0.00 or blank). As a workaround - to force correct price recalculation - user needs to manually alter and then re-alter some price-related fields (e.g., quantity or vendor price). This patch fixes both issues. Test plan: 1) create a suggestion: choose some buget, enter something in 'Price' and 'Quantity' fields, 2) try to make an order from this suggestion, to confirm/replicate aforementioned problems, 3) apply patch, 4) make an order from previously created suggestion again, observe that both issues are now resolved. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.