[Bug 20115] New: Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Bug ID: 20115 Summary: Languages appear in a different order in the footer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The language chooser displays languages in a different order when the page is refresh. It should stick to the same order. A default order can depend on the pref values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71094&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71095&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71096&action=edit Bug 20115: Trigger "modified" when sort is changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 20094 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 [Bug 20116] Cache language list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #5 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Is there a test plan for this? I loaded en-NZ and de-DE translations onto my Kohadevbox but the order still seems pretty random (its different between the staff and the OPAC for example, even after doing a restart_all and refreshing both web pages). Or is it random because the sorting in the syspref isn't written yet? Is that part of this bug (in which case it can't be signed off really) or should it be considered as a separate bug that this one depends on? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I retest and everything looks ok. You need to 1. Install the patch 2. Install or update new languages, for instance: sudo koha-translate --install en-NZ --dev kohadev sudo koha-translate --install fr-FR --dev kohadev sudo koha-translate --install es-ES --dev kohadev 3. Restart all (memcached, plack) Test plan: Search for "language" in the I18N/L10N syspref section and tick/untick and reorder the values as you wish. On the OPAC and staff interfaces you should see the languages displayed with the same order as the pref, and preserved from one reload to the other -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #7 from Dilan Johnpullé <dilan@calyx.net.au> --- Works as described on the staff client side but the order on the opac side remains unchanged regardless of the order of languages set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71661&action=edit Bug 20115: Remove sort on rfc4646_subtag in OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Dilan Johnpullé from comment #7)
Works as described on the staff client side but the order on the opac side remains unchanged regardless of the order of languages set.
True, good catch Dilan. There was another sort in the template, I removed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #10 from Dilan Johnpullé <dilan@calyx.net.au> --- Hi Jonathan I've tested the patch again and the OPAC appears to still be displaying language options completely randomly. I have attempted restarting plack and emptying my cache to no avail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71094|0 |1 is obsolete| | --- Comment #11 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 73027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73027&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71095|0 |1 is obsolete| | --- Comment #12 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 73028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73028&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71096|0 |1 is obsolete| | --- Comment #13 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 73029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73029&action=edit Bug 20115: Trigger "modified" when sort is changed Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71661|0 |1 is obsolete| | --- Comment #14 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 73030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73030&action=edit Bug 20115: Remove sort on rfc4646_subtag in OPAC templates Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Jonathan, it's great feature and works perfectly. Just one small thing: I think that the ability to sort (and the information that the sorted system preference matter) should be descriped on system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73433&action=edit Bug 20115: Add information about this feature in the pref descriptions I guess a native English speaker will have a better wording :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73027|0 |1 is obsolete| | Attachment #73028|0 |1 is obsolete| | Attachment #73029|0 |1 is obsolete| | Attachment #73030|0 |1 is obsolete| | Attachment #73433|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73610&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73611&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73612&action=edit Bug 20115: Trigger "modified" when sort is changed Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73613&action=edit Bug 20115: Remove sort on rfc4646_subtag in OPAC templates Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73614&action=edit Bug 20115: Add information about this feature in the pref descriptions I guess a native English speaker will have a better wording :) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Previous randomly order of release notes| |languages is now fixed to | |alphabetical display. CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the|Previous randomly order of |The languages displayed in release notes|languages is now fixed to |the footer are now |alphabetical display. |displayed in the same order | |as they are in the system | |preferences languages and | |opaclanguages (they can be | |reordered by drag and | |drop). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org