[Bug 30274] New: Non-reservable items should only fill item-level reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Bug ID: 30274 Summary: Non-reservable items should only fill item-level reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com For item types where 'holds allowed(total)' equals 0, you can still place reserves on these non-reservable items via the staff client by overriding the circulation rule. The bug is that, when you check in an item that is non-reservable (holds allowed is 0), it will trigger the holds pop-up and can fill a biblio-level hold ("next available"). The holds pop-up should only be triggered by non-reservable items if there is an item-level reserve on it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23172 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sharon.dugdale@cumbria.gov. | |uk --- Comment #1 from Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> --- We have just noticed this is happening when a non-reservable item is checked in - KOHA is saying that it is available to satisfy a request. We have two library services (Public Libraries and Schools Library Service) using the same system and catalogue, though the stock is NOT inter-changeable and the school stock is shadowed on the OPAC. On occasion school stock is returned to a public library by mistake and when these items are checked in, if a request is pending, KOHA makes it available to satisfy it. The Schools Service does NOT use a request function on KOHA so it would be up to the Public Library staff to identify these errors and ensure these items are NOT trapped for holds. Within the Public Libraries, we also have unreservable and OPAC shadowed stock which may also be affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- Status|ASSIGNED |NEW Assignee|aleisha@catalyst.net.nz |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 168588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168588&action=edit Bug 30274: Prevent non-reservable item to be set as waiting at checkin Test plan: 1. Create a biblio with 2 items: * 1st item: * Barcode: ITEM1 * Item type: TYPE1 * Homebranch and holdingbranch: LIBRARY * 2nd item: * Barcode: ITEM2 * Item type: TYPE2 * Homebranch and holdingbranch: LIBRARY 2. Create a circulation rule for LIBRARY, TYPE1 with "Holds allowed (total)" = 1 3. Create a circulation rule for LIBRARY, TYPE2 with "Holds allowed (total)" = 0 4. Place a biblio-level hold on that biblio with a patron from library LIBRARY. 5. Check in: ITEM2 Without the patch, the "Hold found" popup appears, allowing you to confirm hold for a non-reservable item With the patch, no popup appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | CC| |julian.maurice@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168588|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169874&action=edit Bug 30274: Prevent non-reservable item to be set as waiting at checkin Test plan: 1. Create a biblio with 2 items: * 1st item: * Barcode: ITEM1 * Item type: TYPE1 * Homebranch and holdingbranch: LIBRARY * 2nd item: * Barcode: ITEM2 * Item type: TYPE2 * Homebranch and holdingbranch: LIBRARY 2. Create a circulation rule for LIBRARY, TYPE1 with "Holds allowed (total)" = 1 3. Create a circulation rule for LIBRARY, TYPE2 with "Holds allowed (total)" = 0 4. Place a biblio-level hold on that biblio with a patron from library LIBRARY. 5. Check in: ITEM2 Without the patch, the "Hold found" popup appears, allowing you to confirm hold for a non-reservable item With the patch, no popup appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169874|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169875&action=edit Bug 30274: Prevent non-reservable item to be set as waiting at checkin Test plan: 1. Create a biblio with 2 items: * 1st item: * Barcode: ITEM1 * Item type: TYPE1 * Homebranch and holdingbranch: LIBRARY * 2nd item: * Barcode: ITEM2 * Item type: TYPE2 * Homebranch and holdingbranch: LIBRARY 2. Create a circulation rule for LIBRARY, TYPE1 with "Holds allowed (total)" = 1 3. Create a circulation rule for LIBRARY, TYPE2 with "Holds allowed (total)" = 0 4. Place a biblio-level hold on that biblio with a patron from library LIBRARY. 5. Check in: ITEM2 Without the patch, the "Hold found" popup appears, allowing you to confirm hold for a non-reservable item With the patch, no popup appears. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The patch is causing tests to fail: prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 70/75 # Failed test 'Branchcodes match when hold exists.' # at t/db_dependent/Circulation.t line 6622. # got: undef # expected: 'fPd0uu' # Looks like you failed 1 test of 4. # Failed test 'CanBookBeIssued + needsconfirmation message' # at t/db_dependent/Circulation.t line 6637. t/db_dependent/Circulation.t .. 75/75 # Looks like you failed 1 test of 75. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/75 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 256 (exited 1) Tests: 75 Failed: 1) Failed test: 71 Non-zero exit status: 1 Files=1, Tests=75, 40 wallclock secs ( 0.07 usr 0.02 sys + 23.51 cusr 12.90 csys = 36.50 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Failed QA |In Discussion --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I believe you will need to add a system preference to this behavior, it is altering how holds work at a basic level. Some libraries use 'Holds allowed (total)' = 0 to prevent patrons placing holds, but allow staff to place holds and have them fill. Traditionally 'holdsallowed' is a rule about how many holds can be placed, while 'Hold policy'/'reservesallowed' controls whether or not items can fill holds. I admit, this is a distinction that has confused some libraries in the past, and many will welcome this change, but it should have an on/off switch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Phillip Berg <phillip.berg@mainlib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phillip.berg@mainlib.org --- Comment #7 from Phillip Berg <phillip.berg@mainlib.org> --- Agreed that this conflict can use a solution ASAP. In larger systems of libraries with many holds flying through the system, it will be quite odd whenever a staff member is prompted to fulfill a hold with a non-holdable item. Until this is fixed I guess we'll need to remind staff to refuse the request rather than cancel it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #8 from Jessie Zairo <jzairo@bywatersolutions.com> --- Agreed, there should be an on/off switch. It causes confusion for staff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- It seems there is consensus this should be an option, so I'm taking this bug out of In Discussion. But I agree it needs to have a system preference so libraries who want to preserve the previous behavior can do so. Setting to Failed QA as the current patch make the behavior change non-optional. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org