http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 tadeas.moravec@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39473|0 |1 is obsolete| | --- Comment #2 from tadeas.moravec@gmail.com --- Created attachment 39501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39501&action=edit Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense Signed-off-by: tadeasm <tadeas.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Katrin, 'Show all' is used at several places. If we change one, I think we should change of all them in one go. At least: acqui/addorderiso2709.tt acqui/parcels.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Show all" on order page |"Show all" in acquisition |confusing |confusing -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39709&action=edit Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39709|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40310&action=edit Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple string change, no errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40312&action=edit Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple string change, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.