[Bug 9730] New: The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Bug ID: 9730 Summary: The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: christophe.croullebois@biblibre.com it fails also if 'AnonymousPatron' = 0 With the patch in this case the borrowernumber becomes NULL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |christophe.croullebois@bibl | |ibre.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 15778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15778&action=edit proposed patch To test : Without patch leave 'AnonymousPatron' syspref blanck or with '0' value. Try in Opac/my privacy to use 'Immediate deletion' with a patron who have a reading history. The reading history is still present. With patch, the same context, the reading history is deleted. Thx for testing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I believe it would be more proper to disable the "my privacy' tab if AnonymousPatron is not a valid patron. This would be more in line with how OPACPrivacy requires opacreadinghistory and the tab does not show if opacreadinghistory is not set to "Allow". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15778|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18864&action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15778|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 18864 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-06-12 21:47:50 NZST. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- I don't see comments about the failed QA status ? An error ? So I move in need ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- oups sry Kyle, hum, you suggest to hide the tab in this case ... Ok I'll do a new patch in this way thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 6756 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org