[Bug 21139] New: The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Bug ID: 21139 Summary: The floating toolbars have some issues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 [Bug 21099] Floating toolbars reposition too late -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77379&action=edit Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77380&action=edit Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77381&action=edit Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77382&action=edit Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77383&action=edit Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77379|0 |1 is obsolete| | Attachment #77380|0 |1 is obsolete| | Attachment #77381|0 |1 is obsolete| | Attachment #77382|0 |1 is obsolete| | Attachment #77383|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77391&action=edit Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77392&action=edit Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77393&action=edit Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77394&action=edit Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77395&action=edit Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77391|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77408&action=edit Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77392|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77409&action=edit Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77393|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77410&action=edit Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77394|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77411&action=edit Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77395|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77412&action=edit Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77843&action=edit Bug 21139: (follow-up) Floating toolbars - Remove unecessary height Found where QAing bug 20935, we actually want the hidden toolbar to be the exact same height as the visible one. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03.. awaiting followup to be pushed to master before grabbing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)
Created attachment 77843 [details] [review] Bug 21139: (follow-up) Floating toolbars - Remove unecessary height
Found where QAing bug 20935, we actually want the hidden toolbar to be the exact same height as the visible one.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Folllow-up pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Bug 21139 depends on bug 21099, which changed state. Bug 21099 Summary: Floating toolbars reposition too late https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org