[Bug 34016] New: Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Bug ID: 34016 Summary: Enable fulfillment of recalled items through SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Currently items that have been recalled are not fulfilled properly when they're checked out using SIP2 (i..e a self-check machine). The item is successfully checked out but the recall request is not filled and closed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 152371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152371&action=edit Bug 34016: Tests for fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 152372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152372&action=edit Bug 34016: [WIP] Working on fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152371|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 152396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152396&action=edit Bug 34016: Tests for fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152372|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 152397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152397&action=edit Bug 34016: [WIP] Working on fulfilling recalls via SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Status|ASSIGNED |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152397|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 152458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152458&action=edit Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152396|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 152461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152461&action=edit Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152458|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 152462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152462&action=edit Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement allows SIP release notes| |(using a self-check | |machines) to better handle | |recalled items - preventing | |the check-out of recalled | |items if they have been | |allocated to another | |patron, or fulfilling | |recalls if the item was | |recalled and allocated to | |this patron. --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I applied the first patch ==> tests failed. 2. After applying the second patch (plus a flush_memcached, and restart-all). the tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not talking about: WARN t/db_dependent/SIP/Transaction.t WARN tidiness The file is less tidy than before (bad/messy lines before: 256, now: 280) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152461|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155382&action=edit Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152462|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155383&action=edit Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 155471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155471&action=edit Bug 34016: (QA follow-up) perltidy fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #10)
Not talking about:
WARN t/db_dependent/SIP/Transaction.t WARN tidiness The file is less tidy than before (bad/messy lines before: 256, now: 280)
May as well not introduce untidiness! Have fixed in QA follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32496 CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Rebased on top of (already pushed) bug 32496. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155382|0 |1 is obsolete| | Attachment #155383|0 |1 is obsolete| | Attachment #155471|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156154&action=edit Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 156155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156155&action=edit Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32496 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Bug 34016 depends on bug 32496, which changed state. Bug 32496 Summary: Reduce unnecessary unblessings of objects in Circulation.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Bug 34016 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org