https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123720&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123722&action=edit Screenshot with patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123720|0 |1 is obsolete| | --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 123806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123806&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Barbara Johnson from comment #5)

I went ahead and signed off on this; however, there is one minor typo that needs to be fixed. 'Pre-fill values with profile ?' needs to have the extra space removed between the 'e' and the question mark.

Oh indeed, french-style typo. I fix it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123821|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123822&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123822|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123871&action=edit Bug 28839: Better texts in stage MARC for import Tool stage MARC for import is /cgi-bin/koha/tools/stage-marc-import.pl. Its form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multilines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like "Stage records into the reservoir". Section beginning with "Comments about this file" is missing a legend, it looks like it is part of the upper section for profile. Also lengends should be driving the user, that is why optional parts contains a legend with "?". Test plan : Compare texts in page without and with patch Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28839 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.