[Bug 27505] New: Add new item type controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Bug ID: 27505 Summary: Add new item type controller image for carredart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: liav@wgc.school.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #1 from Ava <liav@wgc.school.nz> --- Created attachment 115489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115489&action=edit Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liav@wgc.school.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115489|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115540&action=edit Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I love new item type images! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115705&action=edit Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115540|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115751&action=edit Bug 27505: Add new item type controller image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small controller icon Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115705|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115752&action=edit Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add new item type |Add new itemtype controller |controller image for |image for carredart |carredart | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115752|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115842&action=edit Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115751|0 |1 is obsolete| | Attachment #115842|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123192&action=edit Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|liav@wgc.school.nz |oleonard@myacpl.org Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123192|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 123276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123276&action=edit Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |video game controller image | |to the carredart icon set | |for item types. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123276|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123931&action=edit Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27521, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27522, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27523 CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27520 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115752|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115751|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Based on bug 27522 comment 22 I have decided to restore the original version of the icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org