[Bug 20629] New: Remove ability to 'reverse' payments.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Bug ID: 20629 Summary: Remove ability to 'reverse' payments. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Blocks: 18790 Now that we have a true ability to void payments in Koha, we should probably remove the reverse payment option which was something of a kludge to begin with. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 [Bug 18790] Add ability to void payments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The feature is quite problematic, +1 for removing it now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove ability to 'reverse' |Remove ability to 'reverse' |payments. |payments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74935&action=edit Bug 20629: Remove ability to 'reverse' payments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8055, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14062, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14140 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, should this be 'Needs Signoff'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18790 |7205, 14062, 11972, 14140 Depends on| |18790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7205 [Bug 7205] can't reverse manual credits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11972 [Bug 11972] Untranslatable "Reversed" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14062 [Bug 14062] Payment note on reversed payment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140 [Bug 14140] Reversed payments don't generate entry in statistics https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 [Bug 18790] Add ability to void payments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply - can you please rebase? CONFLICT (content): Merge conflict in members/printfeercpt.pl Auto-merging members/boraccount.pl CONFLICT (content): Merge conflict in members/boraccount.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt Auto-merging Koha/Account/Line.pm CONFLICT (content): Merge conflict in Koha/Account/Line.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74935|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80590&action=edit Bug 20629 - Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Unblessed doesn't get is_credit or is_debit, only an object would. Either add, or better yet deal with the FIXME. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80590|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80620&action=edit Bug 20629 - Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80620|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80621&action=edit Bug 20629 - Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622&action=edit Bug 20629 - Pass accountline objects to template instead of hashref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 80622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622 Bug 20629 - Pass accountline objects to template instead of hashref Review of attachment 80622: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20629&attachment=80622) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ +75,5 @@
[% ELSE %] <a target="_blank" href="printinvoice.pl?action=print&accountlines_id=[% account.accountlines_id | html %]&borrowernumber=[% account.borrowernumber | html %]" class="btn btn-default btn-xs"><i class="fa fa-print"></i> Print</a> [% END %] <a href="accountline-details.pl?accountlines_id=[% account.accountlines_id | html %]" class="btn btn-default btn-xs"><i class="fa fa-list"></i> Details</a> [% IF ( reverse_col) %]
reverse_col is always 0, because it is passed as 0, and you don't set it above, and you need to set it BEFORE the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 80622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622 Bug 20629 - Pass accountline objects to template instead of hashref Review of attachment 80622: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20629&attachment=80622) ----------------------------------------------------------------- ::: members/boraccount.pl @@ +80,3 @@
}
my $reverse_col = 0; # Flag whether we need to show the reverse column
perhaps two Account lines searches, and merge the array? That will give you the ability to set reverse_col correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80629&action=edit Bug 20629: Follow up - fix reverse_col value Before this patch the Void button didn't appear. After this patch the Void button appears on payments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80630&action=edit Bug 20629: Follow up to add POD for getcharges. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80621|0 |1 is obsolete| | Attachment #80622|0 |1 is obsolete| | Attachment #80629|0 |1 is obsolete| | Attachment #80630|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80631&action=edit Bug 20629: Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80632&action=edit Bug 20629: Pass accountline objects to template instead of hashref Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80633&action=edit Bug 20629: Follow up - fix reverse_col value Before this patch the Void button didn't appear. After this patch the Void button appears on payments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80634&action=edit Bug 20629: Follow up to add POD for getcharges. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80633|0 |1 is obsolete| | Attachment #80634|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80635&action=edit Bug 20629: Follow up - fix reverse_col value Before this patch the Void button didn't appear. After this patch the Void button appears on payments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80636&action=edit Bug 20629: Follow up to add POD for getcharges. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80692&action=edit Bug 20629: Rename to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80692|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80693&action=edit Bug 20629: Rename reverse_col to actions_col -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #21)
Created attachment 80693 [details] [review] Bug 20629: Rename reverse_col to actions_col
I think there was a reason for it to be called reverse_col: it was originally used to make a decision on displaying the column with the reverse button (of course). But right now we really display other things (like the print button, the details button, the void button). We should really remove the conditional display, as it should always be displayed. @mtompset: I will remove your patch with the POD for getcharges, because it is actually getting removed in bug 21681. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80632|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80693|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81311&action=edit Bug 20629: Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81312&action=edit Bug 20629: Pass accountline objects to template instead of hashref Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81313&action=edit Bug 20629: (follow-up) fix reverse_col value Before this patch the Void button didn't appear. After this patch the Void button appears on payments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81314&action=edit Bug 20629: Rename reverse_col to actions_col Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81315&action=edit Bug 20629: (QA follow-up) Remove actions_col The actions_col template param requires a DB search, only to display the 'Actions' column header vs. an empty string. But there will always be buttons in there, that were added *after*. It made sense when only the 'Reverse' button was displayed, but now both 'Print' and 'Details' are displayed anyway. This patch removes it for good :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Doesn't apply anymore, rebasing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81312|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81349&action=edit Bug 20629: Remove ability to 'reverse' payments Test Plan: 1) Apply this patch 2) Note all references to reversing payments have been removed 3) Note ability to void payments remains unchanged Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81350&action=edit Bug 20629: Pass accountline objects to template instead of hashref Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81351&action=edit Bug 20629: (follow-up) fix reverse_col value Before this patch the Void button didn't appear. After this patch the Void button appears on payments. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81352&action=edit Bug 20629: Rename reverse_col to actions_col Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81353&action=edit Bug 20629: (QA follow-up) Remove actions_col The actions_col template param requires a DB search, only to display the 'Actions' column header vs. an empty string. But there will always be buttons in there, that were added *after*. It made sense when only the 'Reverse' button was displayed, but now both 'Print' and 'Details' are displayed anyway. This patch removes it for good :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Fines and fees |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- There were bad rebase somewhere, commit fb15a9631044cd0191c58feb5b8370e9b846136b reintroduces getcharges! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21804 [Bug 21804] Bad rebase reintroduced C4::Accounts::getcharges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org