[Bug 21645] New: Clean up library groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Bug ID: 21645 Summary: Clean up library groups template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/library_groups.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 15707 The library groups template has several issues which need to be cleaned up: - Bootstrap grid - JavaScript to the footer - Markup corrections Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81069&action=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- edit-group classes are twice in some tags delete-group classes are twice in some tags <span>? -- probably should be a closed span. -- the type stuff is in an include file. recheck the div match ups, particularly across include files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81069|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81078&action=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Header looks better in the case of having library groups, but looks out of place when there are none. Perhaps a pretty shaded box telling us how lonely it is with no library groups would be better, but this isn't a blocker for me. The HTML clean up is awesome (96 -> 5 errors, of which the remainder are include files and have nothing to do with this page specifically). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81078|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 81081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81081&action=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81081|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81197&action=edit Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81198&action=edit Bug 21645: e.preventDefault on click Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81199&action=edit Bug 21645: Fix focus when modal is shown First the event must be defined in the document.ready block, then, since bootstrap 3 the event is 'shown.bs.modal', not 'shown' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21645 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org