https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Test plan: * Stage and commit a marc file with a match rule such that a replacement will be triggered (either using the tool in the staff interface or the command line tools) * Code review patch and observe: - If $logged_in_user is undefined the code will crash without patch and will not crash with patch - If $logged_in_user is defined the code will behave identically both with and without patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Andreas. I would like to test (using koha-testing-docker), but I am not familiar enough with the importing records from the command line using misc/stage_file.pl and misc/commit_file.pl. Are you able to provide a test plan for this that has some more detail? I had a go, but there are some steps I'm not sure how to do in steps 1 and 2: 1. Stage and import a record using the staff interface (this should work successfully both before and after the patch is applied): . Have a sample file with records (for example, export some records from Koha with these settings, change the title in the file) . . => Record successfully imported and record updated with new title 2. Stage and import the records using the command line: . Stage the records for importing with these settings: perl misc/stage_file.pl --file koha-bz30520-test.mrc --add-items (notes: default --match rule is to match to ISBN or title; default action is to replace) . Identify the batch number of the staged records: perl misc/commit_file.pl --list-batches (or lookup in the staff interface: Tools > Catalog > Staged MARC record management) . Commit the records for importing with these settings (where # = the batch numbere): perl misc/commit_file.pl --batch-number # --framework BK . What the "crash" or "broken" looks like - error message, error in log files, silent fail, etc. 3. Apply the patch. 4. Repeat steps 1 and 2. 5. Expected result: records are successfully staged and imported - search for XYZ record, should find. 6. Sign off! Also, presumably if you use the staff interface you are already logged in, so it won't produce an error? Or is this just to check that records can still be successfully staged and committed using the staff interface after the patch is applied? David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Andreas.. interestingly I couldn't easily spot where userid and categorycode are actually ever referred to in the overlay context.. but it doesn't appear to break anything. Signing off as unit tests continue to pass and the fix does indeed work as proposed. Might be night to add a unit test for this particular change though ;P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Oh interesting... I found the web based MARC stage and import broken in 21.11 as well. I'm starting to look into it... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think that this is not critical but major btw. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14957 Summary|Command line stage and |Command line stage and |import broken since 21.11. |import broken Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Magnus Enger from comment #13)

The status on this is "Pushed to stable". Is that correct? Should "Version(s) released in" be updated to reflect that?

Looking at the 21.11.x shortlog and I see no evidence that this bug was ever backported beyond 22.05.x: https://git.koha-community.org/gitweb/?p=koha.git;a=shortlog;h=refs/heads/21... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30520 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Restored status.. this really is needed for 21.11.x series.. and doesn't look too terrible to backport. -- You are receiving this mail because: You are watching all bug changes.