https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154689&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154689|0 |1 is obsolete| | --- Comment #2 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 155556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155556&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Couldn't this be simplified? + [% IF ( label_element == 'layout' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'template' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'profile' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'batch' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% END %] To just be? <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> If the outcome is always the same, why do the if/else? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156731&action=edit Bug 33916: (QA follow-up) Remove redundant template code -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155556|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157569&action=edit Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157571&action=edit Bug 33916: (QA follow-up) Correct "Label profiles" ... to "Printer profiles" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33916 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.