[Bug 31422] New: Library limitations might cause data loss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Bug ID: 31422 Summary: Library limitations might cause data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, michaela.sieber@kit.edu The library limitations are used to limit down the selection in pull downs in several spots. If you are editing data from library B while logged in at library A, doing so might result in data loss as the value stored in the modified object might be missing from the drop downs your user sees. Example 1: Item values Itemtype: BK Books - limited to Centerville AV LOC: FIC Fiction - limited to Centerville Your user: logged in for Centerville * Edit an item and make sure it uses the itemtype Books and location Fiction. * Switch library to any but Centerville. * Edit item: Both item type and location drow downs will be empty. * Saving now will empty out itemtype (if not set mandatory) and location resulting in data loss. Example 2: Patron data Patron category: Patron PT - limited to Centerville Your user: logged in for Centerville * Find a patron with the limited patron category * Edit patron: Verify the patron category shows in pull down * Switch library to any but Centerville * Edit patron: the category pull down will show the first entry of the pull down visible for this library. Saving now, you will change the patron category unknowingly resulting in data loss. Additional bug: If you search for "all patrons", you will have an error in the console no patrons will display: Uncaught TypeError: categories_map[data] is undefined. Filed as bug 31421. I think we need to make sure that the pull downs show what the library can use, but also what the current setting of the object is in order to prevent data loss. IIRC the funds pull down on the receive page uses a mechanism for this. Otherwise library limitations are very dangerous to use and can only be recommended if we can make sure that objects from other libraries cannot be edited at all where library limitations have been applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- This is quite frankly, horrifying. I know a lot of large library systems and consortiums use library limitations. I agree with Katrin's solution - show the user what it currently is, and allow me to change if it needed, but don't let me change it to something that I am not permitted to use based on limitations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Donna, I had missed you already found this one! Not getting much attention yet :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19361 CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142259&action=edit Bug 31422: Add patron's current category to dropdown while editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142259|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 142285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142285&action=edit Bug 31422: Add patron's current category to dropdown while editing Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Replicated issue for example 2 in comment #1: . Patron used: Mary Burton (changed library to Centerville) 2. Applied the patch. 3. Retested: . When editing, now displays current patron category (previously it was blank) . Now has an ! icon next to it with this message when you hover over it: "The patron's current category (Patron) is limited to other branches" . If you save without changing the patron category, the patron category remains the same (so no data loss) . If you change the patron category and save, the patron category is changed - if you go to edit it again you can't choose the patron category with the limitation 4. Bug 31421 and bug 19361 deal with the other issues in the description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I am reading the comments, this patch only solves one issue but the description is broader than that? Am I correct? Or will the other issue(s) be addressed separately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Library limitations might |Library limitations might |cause data loss |cause data loss when | |editing patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #6)
If I am reading the comments, this patch only solves one issue but the description is broader than that? Am I correct? Or will the other issue(s) be addressed separately?
Other issues handled on related bugs in 'See also' section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142285|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143050&action=edit Bug 31422: Add patron's current category to dropdown while editing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143051&action=edit Bug 31422: (QA follow-up) Fix terminology and switch icon * fa-exclamation-circle looks more like 'info', but I feel this should be more of a warning, so switched to fa-exclamation-triangle * Changed branches to libraries in message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Nick for tackling this, it was bothering us quite a bit. I wonder if the warning should stand out even more. I have updated the image to fa-exclamation-triangle to give it more of a warning character in the follow-up. Maybe it would be nice to also have a confirmation message if the category was changed? Commit message could have more words! ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119 [Bug 32119] Cannot add new guarantee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #10)
Commit message could have more words! ;)
Yes, definitely! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 32703 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- Can this be backported to 22.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #14)
Can this be backported to 22.05?
This is a string patch, it can be backported during next month's cycle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #15)
(In reply to Christopher Brannon from comment #14)
Can this be backported to 22.05?
This is a string patch, it can be backported during next month's cycle.
Nice. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32748 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- This, and Bug 32119, contain too many merge conflicts for 22.05.x. So no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon@cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147698&action=edit Bug 31422: [22.05.x] Add patron's current category to dropdown while editing Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 31422: (QA follow-up) Fix terminology and switch icon * fa-exclamation-circle looks more like 'info', but I feel this should be more of a warning, so switched to fa-exclamation-triangle * Changed branches to libraries in message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Lucas Gass from comment #17)
This, and Bug 32119, contain too many merge conflicts for 22.05.x. So no backport.
Please test, I did not - you may not need 32119 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33276 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 33458 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 21255 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #17)
This, and Bug 32119, contain too many merge conflicts for 22.05.x. So no backport.
Oh no! We could really use this. That is too bad! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Can we close ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35868 [Bug 35868] Warning sign for using a patron category that is limited to another library has moved to other side of page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36376 [Bug 36376] Display library limitations issue in patron's messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41363 [Bug 41363] Don't hide patron category limitation warning behind icon -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org