[Bug 34428] New: update database create a wrong table transport_cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Bug ID: 34428 Summary: update database create a wrong table transport_cost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Hi, it's using the initial definition from the first patch with : CONSTRAINT `CONSTRAINT_1` CHECK (`frombranch` <> `tobranch`) which never works and doesn't import in Maria db 10.6 Regards Didier, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update database create a |Update database creates a |wrong table transport_cost |wrong table transport_cost Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23995 CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 23995 removed it from kohastructure.sql but still exists in updatedatabase.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #1)
Bug 23995 removed it from kohastructure.sql but still exists in updatedatabase.pl
That's not great... right? It's this update here, still in updatedatabase: $DBversion = "3.09.00.037"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('UseTransportCostMatrix',0,'Use Transport Cost Matrix when filling holds','','YesNo')"); $dbh->do("CREATE TABLE `transport_cost` ( `frombranch` varchar(10) NOT NULL, `tobranch` varchar(10) NOT NULL, `cost` decimal(6,2) NOT NULL, `disable_transfer` tinyint(1) NOT NULL DEFAULT 0, CHECK ( `frombranch` <> `tobranch` ), -- a dud check, mysql does not support that PRIMARY KEY (`frombranch`, `tobranch`), CONSTRAINT `transport_cost_ibfk_1` FOREIGN KEY (`frombranch`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `transport_cost_ibfk_2` FOREIGN KEY (`tobranch`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8"); print "Upgrade to $DBversion done (creating `transport_cost` table; adding UseTransportCostMatrix systempref, in circulation)\n"; SetVersion($DBversion); } Should we fix and try to drop the CHECK in a database update? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #2)
That's not great... right?
Right.
Should we fix and try to drop the CHECK in a database update?
Yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34428 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org