https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I had noticed it before too, but didn't push it further because it's only in the "about" page (sorry!!). The "the's" are separated because the nouns following them are links. For example, The <a href="http://www.myacpl.org/">Athens County Public Libraries</a>, Ohio, USA (MARC sponsorship, documentation, template maintenance) so the translation tool cuts it up in - The - Athens County Public Libraries - , Ohio, USA (MARC sponsorship, documentation, template maintenance) I wonder if adding span tags around the strings would help? I tried on my local installation, and ran gulp po:update --lang fr-CA and it didn't change, but it might just be me not doing it correctly too... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What Caroline said. Set the link in a TT variable, then use it in place of the <a> and the string will appear in a single sentence on pootle/weblate: "The %s Athens County Public Libraries" There is nothing better we can do. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is what I had in mind: admin/curbside_pickup.tt 62 [% SET pref_CurbsidePickup_link = '<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CurbsidePickup">CurbsidePickup</a>' %] 63 <div class="dialog message">The [% pref_CurbsidePickup_link | $raw | $KohaSpan %] preference is not enabled, do not forget to enable it to turn the feature on.</div> Bug 6988 comment 2 is interesting, I never thought about that. It also depends if you want the link to be translatable. Do you want "Athens County Public Libraries" to be translatable? I don't think it's needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Sorry, that might not be a good example because the whole sentence is in the link. But this example The <a href="http://datatables.net/extensions/colvis/">controls for column visiblity in DataTables</a> by Allan Jardine is licensed under the BSD 3 and GPL v2 license. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Owen suggested a way to rewrite the about page that would get rid of a lot of the "the". I beliebe while other suggestions might work, this could be the best option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158074&action=edit Bug 34900: Simplify text of about page license information This patch simplifies the language describing third-party libraries and their licenses so that translation are not so complicated. The patch also removes information about some assets which are no longer part of Koha. The license information now lists only the library name, version (if possible) and license. To test, apply the patch and go to the about page in the staff interface. Open the "Licenses" tab and check the content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- Added assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159448|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 159502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159502&action=edit Bug 34900: (follow-up) Correct last entry Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #17 from David Nind <david@davidnind.com> --- I probably got a bit carried away with the follow-up - possibly outside the scope of the bug? Happy to put in a separate bug! License names: I used the full name and made consistent (for example: MIT License, instead of MIT or MIT license; GNU General Public License vX, instead of GPL or General public license). I did think about using abbreviations used at https://docs.github.com/en/repositories/managing-your-repositorys-settings-a... or https://opensource.org/licenses/ Hopefully this helps a bit with translation. Questions for other bugs, if required: - Should the version of a piece of software be shown? A few do. - Should we have a short description of what they do, where they are used in Koha? - Should we change to a bullet list? - Versions of libraries: many seem quite old or not updated for a while. . Should I create an omnibus bug to update? . Should we update all libraries used at the start of a cycle? (The biggies, such as Bootstrap and jQuery, might be more problematic.) . Or do we have a "if it isn't broken, don't fix it" approach, unless there are security updates? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Also, no entry for DataTables itself. Is there a reason or should I open a ticket to report it? Some opinions about: (In reply to David Nind from comment #17)

Questions for other bugs, if required: - Should the version of a piece of software be shown? A few do.

Might be tough to be reliably maintained. Maybe not actually, it's not often to have library updates and a QA guideline to remind to keep the about page up to date would do.

- Should we have a short description of what they do, where they are used in Koha?

Maybe, if someone wants to volunteer to implement it why not. Or maybe we prefer to spare any new string for translators unless necessary? Or even a few dozen are not a big deal?

- Should we change to a bullet list? - Versions of libraries: many seem quite old or not updated for a while. . Should I create an omnibus bug to update?

Now that you remention it, it might have enough value as a technical documentation. Both for regular development and when looking at security issues. Oops, I understood that as creating a ticket to add the version for all libraries. Answer to your question comes later down.

. Should we update all libraries used at the start of a cycle? (The biggies, such as Bootstrap and jQuery, might be more problematic.)

Even the small ones, multiple of them might need to test and tweak a lot of pages. So overall it might be equivalent like if we had another (or multiple more?) Bootstrap, jQuery, datatable.

. Or do we have a "if it isn't broken, don't fix it" approach, unless there are security updates?

Seems like the current situation due to limited resources. It's seems hard enough at the moment to keep the biggies up to date. Unless there is some spare capacity after catching up for security, compatibility, big bugfixes. Until then it's tough to plan for general updates of the rest. If someone needs a new feature or just has an itch for updating a library it can still happen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

After a quick look, that looks like a mistake, so should be added back in.

ok, thanks for the confirmation, still needs work then.

I've just had a quick look (not comprehensive), and it looks like there are some software licences missing, including: [...] Maybe this should be a separate bug to review what is used and add any missing ones?

Indeed that would be another ticket. There doesn't seem to be an existing one, so here is Bug 35584 feel free to change stuff and add details if needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160069&action=edit Bug 34900: (follow-up) Add version information to more entries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- If I read the comments correctly the issue of missing libraries was what caused this to be Failed QA, and now that's in a separate bug. As such I'm putting this back to "Signed off." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #25 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #24)

If I read the comments correctly the issue of missing libraries was what caused this to be Failed QA, and now that's in a separate bug. As such I'm putting this back to "Signed off."

That sounds fine to me! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159501|0 |1 is obsolete| | Attachment #159502|0 |1 is obsolete| | Attachment #159503|0 |1 is obsolete| | Attachment #160070|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160522&action=edit Bug 34900: Simplify text of about page license information This patch simplifies the language describing third-party libraries and their licenses so that translation are not so complicated. The patch also removes information about some assets which are no longer part of Koha. The license information now lists only the library name, version (if possible) and license. To test, apply the patch and go to the about page in the staff interface. Open the "Licenses" tab and check the content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160524&action=edit Bug 34900: (follow-up) List alphabetically and tidy ups Listed in alphabetical order (except for Koha, which is listed at the start). Tidy ups and consistency changes: - end of each entry: remove full stops - separator between software and license: use a colon - headings for software/library name: use sentence case unless a noun, abbreviation, or the actual software name - http and https: use https where site uses it - URLs: update where required - license names: use consistent full names with title case Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.