[Bug 19241] New: Items with status of hold show as available in cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Bug ID: 19241 Summary: Items with status of hold show as available in cart Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: michael@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 66784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66784&action=edit attachment shows item with status on hold in cart showing as available Items that have status of on hold show as available on cart list. While users can observe the item has the status of on hold before putting it in the cart, it was reported some patrons find this inconsistency confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org --- Comment #1 from Ed Veal <eveal@mckinneytexas.org> --- This bug has been showing "New" for 8 months. Owen, might we take a look at this and see what we can do? Ed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|16.11 |master Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 NancyK. <nkeener@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener@washoecounty.us --- Comment #2 from NancyK. <nkeener@washoecounty.us> --- I just got a complaint on this. Could someone please fix it? Thanks NancyK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88093&action=edit Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88093|0 |1 is obsolete| | --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 88127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88127&action=edit Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88127|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88690&action=edit Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions found, simple fix. Thanks all, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- can't rebase for 18.05.x Global symbol "$borcat" requires explicit package name (did you forget to declare "my $borcat"?) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org