https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 186574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186574&action=edit Bug 40840: Failure of an EDI SFTP account will kill edi_cron.pl preventing uploads from subsequent accounts EDI uploads are processed in order. If one account is unable to connect to the SFTP server, it will call die_on_error which kills the script. This does not affect regular FTP which will fail gracefully. Test Plan: 1) Set up an SFTP server 2) Set up 3 EDI accounts 3) Set accounts 1 and 3 to have a good SFTP server hostname 4) Set account 2 to have a bad SFTP server hostname 5) Queue an edi order for each account 6) Run edi_cron.pl 7) Note the cronjob runs and dies with an error 8) Note only 1 EDI message was uploaded 9) Apply this patch 10) Run edi_cron.pl 11) Note that the cronjob does not die 12) Verify the message for account 3 was uploaded! ( the message for account 2 should remain as pending ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Does someone have an SFTP server/account that could be used to test this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200495&action=edit Bug 40840: Failure of an EDI SFTP account will kill edi_cron.pl preventing uploads from subsequent accounts EDI uploads are processed in order. If one account is unable to connect to the SFTP server, it will call die_on_error which kills the script. This does not affect regular FTP which will fail gracefully. Test Plan: 1) Set up an SFTP server 2) Set up 3 EDI accounts 3) Set accounts 1 and 3 to have a good SFTP server hostname 4) Set account 2 to have a bad SFTP server hostname 5) Queue an edi order for each account 6) Run edi_cron.pl 7) Note the cronjob runs and dies with an error 8) Note only 1 EDI message was uploaded 9) Apply this patch 10) Run edi_cron.pl 11) Note that the cronjob does not die 12) Verify the message for account 3 was uploaded! ( the message for account 2 should remain as pending ). Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize (ashimema) from comment #4)

This is only required for 25.05 at this stage as the transport system was reworked for 25.11 and beyond.

Should this have a rel-keyword for 25.05 then? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Could I please get a more detailed test plan? 1) Set up an SFTP server How do I do this? I tried following Kyle's steps on Comment #3 but I can't install openssh-server from within the ktd --shell 2) Set up 3 EDI accounts How do you do this? 3) Set accounts 1 and 3 to have a good SFTP server hostname What is a good hostname? 4) Set account 2 to have a bad SFTP server hostname What is a bad hostname? etc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40840 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I can't really make the test plan any simpler.. you need to work with third parties and understand ftp protocols.. to be honest. I've had this backported to o5th for a while and I'm sure ByWater are also running it in production.. EDI is broken if you happen to have a typo in your connection settings for any EDI account without this patch. -- You are receiving this mail because: You are watching all bug changes.