[Bug 42300] New: OPAC detail page: authority links have no text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Bug ID: 42300 Summary: OPAC detail page: authority links have no text Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Go to the OPAC detail page for a record with authority links. 2. Notice the magnifying glass icon is link but there is no text or aria label for screen readers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196957&action=edit Bug 42300: Add title and aria-label to authlink on the OPAC detail page To test: 1. Go to the OPAC detail page for a record with authority links. 2. Notice the magnifying glass icon is link but there is no text or aria label for screen readers 3. APPLY PAATCH, restart_all, clear browser cache 4. Repeat steps 1 -2. 5. You should see both an aria-label and a title labeled "View authority record" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 196971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196971&action=edit Bug 42300: Add title and aria-label to authlink on the OPAC detail page To test: 1. Go to the OPAC detail page for a record with authority links. 2. Notice the magnifying glass icon is link but there is no text or aria label for screen readers 3. APPLY PAATCH, restart_all, clear browser cache 4. Repeat steps 1 -2. 5. You should see both an aria-label and a title labeled "View authority record" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an accessibility release notes| |issue on OPAC details pages | |for magnifying glass icon | |links to authority records: | |"Links must have | |discernible text". | | | |The magnifying glass icon | |links now have a title and | |aria label "View authority | |record". CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For Programme Perl (/cgi-bin/koha/opac-detail.pl?biblionumber=262), using axe DevTools: - Links must have discernible text - 5 occurrences before the patch - No occurrences of this issue after the patch 2. After the patch, an example for an authority record magnifying glass link - now has a title and aria label: <a class="authlink" href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=482" title="View authority record"> <i class="fa fa-search" aria-label="View authority record"></i></a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du --- Comment #4 from Dani Elder <danielle.elder@law.utexas.edu> --- This would be very helpful to have backported. As a public institution we have ADA Title II requirements and this particular issue is driving our accessibility compliance down. The web scanner my institution uses counts each instance of this icon as non-compliance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 197342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197342&action=edit Bug 42300: Add title and aria-label to authlink on the OPAC detail page To test: 1. Go to the OPAC detail page for a record with authority links. 2. Notice the magnifying glass icon is link but there is no text or aria label for screen readers 3. APPLY PAATCH, restart_all, clear browser cache 4. Repeat steps 1 -2. 5. You should see both an aria-label and a title labeled "View authority record" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial and straightforward - QAing despite same company ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate, | |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #8 from Dani Elder <danielle.elder@law.utexas.edu> --- Thanks for all the work on this everyone, since is is trivial can it be backported? Would be nice to have this accessible feature sooner than later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Dani Elder from comment #8)
Thanks for all the work on this everyone, since is is trivial can it be backported? Would be nice to have this accessible feature sooner than later.
I hope so! I marked this as a rel_25_05_candidate and a rel_25_11_candidate for backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Raina <raina@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raina@flo.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- For 25.05 - the title and aria-label seem to already be there before the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.05 |26.05.00,25.11.05,25.05.17 released in| | --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Wainui Witika-Park from comment #11)
For 25.05 - the title and aria-label seem to already be there before the patch
Sorry I was mistaken Backported to 25.05.x for 25.05.17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42300 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldoldstable |Needs documenting --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 24.11.x LTS for stability and avoid translation work. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org