[Bug 38827] New: New search performed when column filters lose focus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Bug ID: 38827 Summary: New search performed when column filters lose focus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com On a table using DataTables and the REST API wrapper with the column filters, if one input is used to filter the table the query will be made twice: when the user stopped typing and when the input will lose the focus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176147&action=edit Bug 38827: DataTables - Do not filter when inputs lose focus On a table using DataTables and the REST API wrapper with the column filters, if one input is used to filter the table the query will be made twice: when the user stopped typing and when the input will lose the focus. Test plan: Search for patron Open the dev console, "Network" tab In the "Card" column filter enter "0000" Notice that the table is filtered and that a request has been made Click outside of the "Card" input => Without this patch another request (the same) is made and the table updated => With this patch applied no request is made when the input loses the focus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176147|0 |1 is obsolete| | --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 176162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176162&action=edit Bug 38827: DataTables - Do not filter when inputs lose focus On a table using DataTables and the REST API wrapper with the column filters, if one input is used to filter the table the query will be made twice: when the user stopped typing and when the input will lose the focus. Test plan: Search for patron Open the dev console, "Network" tab In the "Card" column filter enter "0000" Notice that the table is filtered and that a request has been made Click outside of the "Card" input => Without this patch another request (the same) is made and the table updated => With this patch applied no request is made when the input loses the focus. Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jake.deery@ptfs-europe.com --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- Worked for me, nice optimisation. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176162|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176197&action=edit Bug 38827: DataTables - Do not filter when inputs lose focus On a table using DataTables and the REST API wrapper with the column filters, if one input is used to filter the table the query will be made twice: when the user stopped typing and when the input will lose the focus. Test plan: Search for patron Open the dev console, "Network" tab In the "Card" column filter enter "0000" Notice that the table is filtered and that a request has been made Click outside of the "Card" input => Without this patch another request (the same) is made and the table updated => With this patch applied no request is made when the input loses the focus. Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38116 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes DataTable tables release notes| |to stop duplicate update | |queriess being made when | |values are entered for | |filters and then the focus | |is lost (for example, | |clicking somewhere else on | |the screen). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes DataTable tables |This fixes DataTable tables release notes|to stop duplicate update |to stop duplicate update |queriess being made when |queries being made when |values are entered for |values are entered for |filters and then the focus |filters and then the focus |is lost (for example, |is lost (for example, |clicking somewhere else on |clicking somewhere else on |the screen). |the screen). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org