[Bug 36836] New: Review eUsage module for translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Bug ID: 36836 Summary: Review eUsage module for translation issues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com, matt.blenkinsop@ptfs-europe.com, michaela.sieber@kit.edu When testing the eUsage module in 23.11 we noticed a lot of untranslated strings. It might be worth combing through those files to check all strings are marked for translation correctly and then have a second go checking they show up after translating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review eUsage module for |Review ERM module for |translation issues |translation issues Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 170929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170929&action=edit Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }}</a To test: * Apply patch * Run yarn build * Make sure you have a clean work space in git * Run gulp po:update lang de-DE (or another language) * Verify the strings from the patch set now appear in the po files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some more issues I found but failed to fix. Maybe someone more knowledgeable about vue can help with these? 1) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue All 4 alert(...) messages 2) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersCounterLogs.vue render: function (data, type, row, meta) { const importer = row.borrowernumber ? `<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row.borrowernumber}">Borrowernumber ${row.borrowernumber}</a>` : __("Cronjob") return importer }, I also suspect some other things to not translate, but might be easier to see in the GUI later and report separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #2)
There are some more issues I found but failed to fix.
Maybe someone more knowledgeable about vue can help with these?
1) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsReportBuilder.vue
All 4 alert(...) messages
Try this.$__("your string"))
2) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsDataProvidersCounterLogs.vue render: function (data, type, row, meta) { const importer = row.borrowernumber ? `<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row. borrowernumber}">Borrowernumber ${row.borrowernumber}</a>` : __("Cronjob") return importer },
I also suspect some other things to not translate, but might be easier to see in the GUI later and report separately.
"Borrowernumber" won't be translatable I'd say. Try "<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s</a>".format(${row.borrowernumber}, __("Borrowernumber %s").format(${row.borrowernumber})) But I am not sure we want to use "Borrowernumber" here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
(In reply to Katrin Fischer from comment #2)
There are some more issues I found but failed to fix.
Maybe someone more knowledgeable about vue can help with these?
1) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsReportBuilder.vue
All 4 alert(...) messages
Try this.$__("your string"))
I already tried that I think and it didn't pick up the translations. I am a bit confused as to when to use what and mostly looked at other spots "similar" to what I was trying to do. Some notes on the wiki would be quite helpful.
2) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsDataProvidersCounterLogs.vue render: function (data, type, row, meta) { const importer = row.borrowernumber ? `<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row. borrowernumber}">Borrowernumber ${row.borrowernumber}</a>` : __("Cronjob") return importer },
I also suspect some other things to not translate, but might be easier to see in the GUI later and report separately.
"Borrowernumber" won't be translatable I'd say.
Try "<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s</a>". format(${row.borrowernumber}, __("Borrowernumber %s").format(${row.borrowernumber}))
But I am not sure we want to use "Borrowernumber" here...
Similar for me, but I thought that could be a discussion for later. Maybe if this patch is OK we can move them to a separate bug for later, as I am not sure when I can work on the follow-up (already had this patch sitting for a few weeks). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #4)
(In reply to Jonathan Druart from comment #3)
(In reply to Katrin Fischer from comment #2)
There are some more issues I found but failed to fix.
Maybe someone more knowledgeable about vue can help with these?
1) koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsReportBuilder.vue
All 4 alert(...) messages
Try this.$__("your string"))
I already tried that I think and it didn't pick up the translations. I am a bit confused as to when to use what and mostly looked at other spots "similar" to what I was trying to do. Some notes on the wiki would be quite helpful.
<template> part {{ $__("This way") }} <script> part this.$__("This way") The only exception is when we are trying to translate a string that will be displayed in a DataTable (as we are not using a proper Vue component for that), we need to access the global __() function (see js/vue/i18n/index.js) and so use the regular way: __("This way") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35374 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I have noticed that strings from UsageStatisticsReportBuilder.vue are not picked by the translation script. The problem is ES6 template literals, same as bug 35374. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #6)
I have noticed that strings from UsageStatisticsReportBuilder.vue are not picked by the translation script.
Not all the strings, the ones after the first backticks (in getData) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37805 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have split out the translation issue for the alerts into a separate bug report: Bug 37805 - ERM module partially untranslatable So we can move on with this patch which I believe covers what was working in my tests and have the other problems separate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170929|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173261&action=edit Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }}</a To test: * Apply patch * Run yarn build * Make sure you have a clean work space in git * Run gulp po:update lang de-DE (or another language) * Verify the strings from the patch set now appear in the po files Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Some observations thought I don't think blockers: - $__("(EBSCO)") should this be translatable as it's the name of a service? - $__("(local)") should this not leave the parenthesis out of the translate string? - $__("Uploaded on:") should this not leave the colon out of the translate string? - $__("SUSHI credentials") maybe leave 'SUSHI' out of this and consider just the word 'credentials' for translation? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #10)
Some observations thought I don't think blockers: - $__("(EBSCO)") should this be translatable as it's the name of a service?
We could leave it out, but I think it doesn't hurt to have it. I am not sure if EBSCO is used somewhere where they would spell it in Kyrillic or another script, but we keep the option that way.
- $__("(local)") should this not leave the parenthesis out of the translate
We could totally do that, but I was not sure how - dabbling for the first time in this area. I think it's not a blocker for translation.
string? - $__("Uploaded on:") should this not leave the colon out of the translate string?
Again, we could and it might be nice, but I was not sure about how to do a proper concatenation here. There is no general rule and you will find tons of strings with : in the po files.
- $__("SUSHI credentials") maybe leave 'SUSHI' out of this and consider just the word 'credentials' for translation?
In some languages the sequence might be different or, like in German, you need to add a hyphen between words: SUSHI-Logindaten. So no, don't try to make strings more granular, context is important. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38058 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #11)
(In reply to Pedro Amorim from comment #10)
- $__("Uploaded on:") should this not leave the colon out of the translate string?
Again, we could and it might be nice, but I was not sure about how to do a proper concatenation here. There is no general rule and you will find tons of strings with : in the po files.
Not from .vue files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- I am not sure about the changes in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue - >{{ $__(item.tab_name) }}</a + >{{ $item.tab_name }}</a So not using the translated version. Then later: + { + test: "TR", + data_type: "title", + tab_name: this.$__("Titles"), + }, Is this correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- In koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsReportBuilder.vue - >{{ $__(prop.name) }}:</label + >{{ $prop.name }}:</label - {{ $__(month.short) }} + {{ $month.short }} Extra '$' here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173261|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174839&action=edit Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }}</a To test: * Apply patch * Run yarn build * Make sure you have a clean work space in git * Run gulp po:update lang de-DE (or another language) * Verify the strings from the patch set now appear in the po files Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Amended-by: Jonathan Druart - {{ $__("Uploaded on:") }} + {{ $__("Uploaded on") }}: Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #13)
I am not sure about the changes in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsDataProvidersShow.vue
- >{{ $__(item.tab_name) }}</a + >{{ $item.tab_name }}</a
So not using the translated version. Then later:
+ { + test: "TR", + data_type: "title", + tab_name: this.$__("Titles"), + },
Is this correct?
It's been a while since I tested this. To my knowledge translation tools will not work with variables?
- >{{ $__(item.tab_name) }}</a
So this should not work as the tools cannot figure out where the strings are to be found. So removed there and added the translation mark-up to the strings that tab_name can be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #14)
In koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ UsageStatisticsReportBuilder.vue
- >{{ $__(prop.name) }}:</label + >{{ $prop.name }}:</label
- {{ $__(month.short) }} + {{ $month.short }}
Extra '$' here?
I am really not good with the vue syntax yet, I am more guessing than knowing - can you fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174887&action=edit Bug 36836: Amend translation fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37397 CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
* Using double quotes instead of single around strings according to coding guidelines
For the record, cases like `description: __('By month'),` that are left with single quotes should be ok. For another topic I tried on another page that had `:placeholder="$__('License name')"` and a single quote in the translated string and it was displayed and no JS error popped. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174839|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 175021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175021&action=edit Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }}</a To test: * Apply patch * Run yarn build * Make sure you have a clean work space in git * Run gulp po:update lang de-DE (or another language) * Verify the strings from the patch set now appear in the po files Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Amended-by: Jonathan Druart - {{ $__("Uploaded on:") }} + {{ $__("Uploaded on") }}: Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174887|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 175022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175022&action=edit Bug 36836: Amend translation fixes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes multiple release notes| |translation issues for the | |ERM module, including | |missing strings and | |following the coding | |guidelines. --- Comment #22 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To update the translation .po files with new strings: gulp po:update --lang de-DE 2. Checked misc/translator/Koha-messages-js.pot for a sample of updated or new strings, for example: SUSHI, Update bibliographic record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you so much, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175021|0 |1 is obsolete| | Attachment #175022|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176649&action=edit Bug 36836: Fix translation issues in ERM module This tries to fix multiple translation issues in the ERM module. This includes: * Making strings translatable * Using double quotes instead of single around strings according to coding guidelines * Fixing some translations where the variable was marked for translation, but not the strings themselves: ...>{{ $__(item.tab_name) }}</a To test: * Apply patch * Run yarn build * Make sure you have a clean work space in git * Run gulp po:update lang de-DE (or another language) * Verify the strings from the patch set now appear in the po files Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Amended-by: Jonathan Druart - {{ $__("Uploaded on:") }} + {{ $__("Uploaded on") }}: Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176650&action=edit Bug 36836: Amend translation fixes Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176725&action=edit Bug 36836: (follow-up) Fix incorrect syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you so much, Matt! Picking follow-up for main right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 --- Comment #29 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #30 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #31 from David Nind <david@davidnind.com> --- Translation related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org