http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32011&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in <installdir>/etc/sms/driver/<driver>.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in <installdir>/etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32013&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers Fixed a variable name -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Conflict in C4::SMS Applying: Bug 13029: Allow to pass additional parameters to SMS::Send drivers fatal: sha1 information is lacking or useless (C4/SMS.pm). probably from pushed bug #3186: https://github.com/Koha-Community/Koha/commit/03038897467f811670250977a3889f... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32013|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34403&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in <installdir>/etc/sms/driver/<driver>.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in <installdir>/etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Wouldn't it make sense to also document this new feature in the POD of C4/SMS.pm? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- The patch uses this: C4::Context->config('installdir') There is no trace of installdir in current Koha. According to Joubu on IRC this config variable was introduced by the Solr work and later removed. Comments 6 and 7 also need to be addressed. -- You are receiving this mail because: You are watching all bug changes.