[Bug 14980] New: Add a page showing one news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Bug ID: 14980 Summary: Add a page showing one news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. It allows to create custom pages a little bit like : http://wiki.koha-community.org/wiki/Koha_as_a_CMS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 43263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43263&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This patch is a POC, open to changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12806 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7840 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #3 from Marc Véron <veron@veron.ch> --- Fridolin, I like the feature very much! Thinking about enhancements (not necessarily for this bug, it is rather a wishlist): - I would like to see the page id in the staff client (Home > Tools > News). The current column 'Number' could be renamed to 'Sort'. - Flag news to display only as CMS page - Flag news for "Display for logged in users only". Oh, and then, additionally flag news for certain user categories only - Make it possible to include other news in a news. Let's say you have a 'news' with opening hours and an other one with the staff mebers. It would be nice to make them re-usable as page content inside other news. Marc PS: (One small thing in opac/opac-page.pl,line 2 says "This script lets the users change their privacy rules") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43263|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 43340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43340&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #3)
- I would like to see the page id.... I mean the news id that is used to create the link.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marc Véron from comment #5)
(In reply to Marc Véron from comment #3)
- I would like to see the page id.... I mean the news id that is used to create the link.
Indeed, I was thinking to even show the OPAC full url. So one can copy/paste into OPACNav for example. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marc Véron from comment #3)
PS: (One small thing in opac/opac-page.pl,line 2 says "This script lets the users change their privacy rules")
Oups, copy/paste error, I change it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43340|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 43397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43397&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- @Marc Please re-signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marc Véron from comment #3)
- Flag news to display only as CMS page
I think this is the first feat to develop. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43397|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 43404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
- Note its number, for example 3 This may not be clear : its the primary key, the id of the news.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #13 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- My two cents on what needs to go in before this can be integrated in master: - easy access to the url of the page (as Fridolin suggested, a linkn column where you can copy the link with the news id would be perfect) - ability to flag such pages as "CMS only", I would say this kind of page is definitely not going to appear in the news flow, but maybe some people will want to use it this way. - make sure multiple languages are properly managed. This is trickier. If I build my menu in opacnav for instance, i will not be able to build a different menu, with different page ids, for different languages. So choosing OPAC (fr-FR) as the display location is not quite enough, because equivalent pages in each language will end up with different ids. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #14 from Marc Véron <veron@veron.ch> --- (In reply to Gaetan Boisson from comment #13) (...)
- make sure multiple languages are properly managed. This is trickier. If I build my menu in opacnav for instance, i will not be able to build a different menu, with different page ids, for different languages. So choosing OPAC (fr-FR) as the display location is not quite enough, because equivalent pages in each language will end up with different ids.
Gaetan, I think the translation handling could be based on or similar to Bug 14100 - Generic solution for language overlay -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 43404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404 Bug 14980 - Add a page showing one news Review of attachment 43404: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14980&attachment=43404) ----------------------------------------------------------------- Some small issues, noted below, and 2 other things: 1) You can access internal news (staff interface) via guessing ids. (blocker) 2) The feature is too hidden for my taste as we don't even show the id internally. A link 'Show in OPAC' or similar could be helpful. I'd also like to encourage you to talk to Viktor Sarge - I know he has been working on adding a 'Mini-CMS' feature to Koha and I think there are already some patches for small steps in that direction available on bugzilla. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt @@ +29,5 @@
+ + <div id="page-main"> + <h4 class="newsheader">[% data.title | html %]</h4> + <div class="newsbody">[% data.new %]</div> + <div class="newsfooter">(published on [% data.expirationdate %])</div>
Please take a look at bugs 14246-14246 - it's a new feature that just passed QA that will allow to also display the author of a news. ::: opac/opac-page.pl @@ +15,5 @@
+# You should have received a copy of the GNU General Public License +# along with Koha; if not, see <http://www.gnu.org/licenses>. + +use strict; +use warnings;
Please always use Modern::Perl; @@ +31,5 @@
+ { + template_name => "opac-page.tt", + query => $query, + type => "opac", + authnotrequired => 1,
Please check if this should be: authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #16 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Nice idea. I added Martin Persson to the CC-list since he has developed something similar during our project, but I'm not shure if there is any Buzilla thread for it. We want to expand the news with an news archive as well + some other patches making the news a plausible replacement for a separate blog. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13376 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org