[Bug 37057] New: OPACShowUnusedAuthorities displays unused authorities regardless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Bug ID: 37057 Summary: OPACShowUnusedAuthorities displays unused authorities regardless Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To replicate: 1. Create a topic term authority "Example" 2. Duplicate that authority so there are two 3. Find a record and add the topical term "Example" 4. Link the topical term in the record to one of the two Example authorities. 5. Set OPACShowUnusedAuthorities to show. 6. Ensure OpacAuthorities is set to Allow. 7. Search Authorities in the OPAC for "Example" A list should be returned with Example listed twice. One of the authorities should display it is linked to a record and one should be "0" for no link. 8. Change OPACShowUnusedAuthorities to don't show 9. Refresh the page and repeat the authority search for "Example" See that the search results are identical. The Example result with no linked records still displays. I would have expected it to not display, unless there is some other preference or option that needs to be set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Severity|enhancement |normal Keywords| |regression Depends on| |12478 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- That would be from bug 12478 in https://git.koha-community.org/Koha-community/Koha/commit/0002bbc72a42b4c422... - apparently at one point, Elasticsearch hadn't yet implemented authority usage counts, so they just commented out the whole OPACShowUnusedAuthorities feature for ES and Zebra, and left it that way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167629&action=edit Bug 37057: Restore filtering of unused authorities Bug 12478 commented this code out, however, we do return the 'used' parameter in ES authority searches. While we should implement the feature for both ES and Zebra as an index, we can restore this behaviour here. To test: 1 - Search authorities on OPAC with SearchEngine syspref set to both Elasticsearch and Zebra I just searched for 'a' 2 - Confirm results with no usage are included 3 - Test with both values of OPACShowUnusedAuthorities 4 - Apply patch 5 - Repeat searches with both engines and syspref settings 6 - Confirm unused authorities not shown in either engine when syspref is "Don't show" 7 - Conifrm unused authorities shown in both engines when syspref is "Show" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37069 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167629|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 167705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167705&action=edit Bug 37057: Restore filtering of unused authorities Bug 12478 commented this code out, however, we do return the 'used' parameter in ES authority searches. While we should implement the feature for both ES and Zebra as an index, we can restore this behaviour here. To test: 1 - Search authorities on OPAC with SearchEngine syspref set to both Elasticsearch and Zebra I just searched for 'a' 2 - Confirm results with no usage are included 3 - Test with both values of OPACShowUnusedAuthorities 4 - Apply patch 5 - Repeat searches with both engines and syspref settings 6 - Confirm unused authorities not shown in either engine when syspref is "Don't show" 7 - Conifrm unused authorities shown in both engines when syspref is "Show" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I used the word 'central' to show used and unused terms on the search results. 2. The pagination for OPAC authority search results is currently not working (not because of this bug). If you try and navigate to the next page of results, it just returns you to the authority search form. I have logged Bug 37086 for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167705|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168271&action=edit Bug 37057: Restore filtering of unused authorities Bug 12478 commented this code out, however, we do return the 'used' parameter in ES authority searches. While we should implement the feature for both ES and Zebra as an index, we can restore this behaviour here. To test: 1 - Search authorities on OPAC with SearchEngine syspref set to both Elasticsearch and Zebra I just searched for 'a' 2 - Confirm results with no usage are included 3 - Test with both values of OPACShowUnusedAuthorities 4 - Apply patch 5 - Repeat searches with both engines and syspref settings 6 - Confirm unused authorities not shown in either engine when syspref is "Don't show" 7 - Conifrm unused authorities shown in both engines when syspref is "Show" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick fix Nick.. all working as expected again now. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes authority release notes| |searching in the OPAC. | |Using the | |OPACShowUnusedAuthorities | |system preference now works | |as expected when using | |Zebra and Elasticsearch | |search engines: | |- if set to | |"Show", unused authorities | |are shown in the search | |results | |- if set to "Don't | |show", unused authorities | |are not shown in the search | |results. | |A regression was | |causing unused authorities | |to show in the search | |results when the system | |preference was set to | |"Don't show". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org