[Bug 37158] New: OPAC recalls history table not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Bug ID: 37158 Summary: OPAC recalls history table not responsive Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32341 There are some errors in the markup of the OPAC's recalls history page which is preventing the DataTable from behaving responsively. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 [Bug 32341] Some OPAC tables are not displayed well in mobile mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167978&action=edit Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167978|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168001&action=edit Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168001|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168264&action=edit Bug 37158: Make OPAC recalls history table responsive Some markup errors in the OPAC recalls history template are causing the table to not be responsive even though the DataTable is configured to be responsive. This patch corrects it. Also changed: - Removed obsolete <span class="tdlabel">, a remnant of the way we did responsive tables before the DataTable option - Removed very obsolete "type" attribute from the <script> tag and very obsolete "<![CDATA" marker from the script block. - Removed <span>s which were used in the obsolete "title-string" method of sorting a DataTable. To test you must have recalls enabled and have at least one circulation rule which allows for recalls. - Log in to the OPAC as a user who can place recalls. - Locate an item which is elligible for recall and place the recall. - Go to your user summary page, and click the "Recalls history" link in the sidebar. - Confirm that the table of recalls on that page behaves correctly. It should adjust well to varying browser widths. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Much better, thanks Owen. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Bug 37158 depends on bug 32341, which changed state. Bug 32341 Summary: Some OPAC tables are not displayed well in mobile mode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37158 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org