[Bug 21426] New: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Bug ID: 21426 Summary: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P3 Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org I recently set up a new Koha 18.05 instance for testing and decided not to use memcached. So, in /etc/koha/koha-sites.conf I set the USE_MEMCACHED variable to "no" and ran `koha-create --create-db dev`. Oddly enough, once my instance was up and running I noticed that a memcached process had been started (Home > About Koha in the Staff interface also reported memcached as running). Apparently, setting USE_MEMCACHED to "no" does no longer have any effect because (as of Bug 18342) memcached is enabled by default for new installs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79481&action=edit Bug 21426: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect Setting USE_MEMCACHED to "no" in /etc/koha/koha-sites.conf does not have any effect, because as of Bug 18342 memcached is enabled by default for new installations. With the proposed patch this potential source of confusion is removed from the configuration file. Test plan: 1) view koha-sites.conf and notice that you are given the option to set USE_MEMCACHED to either "yes" or "no" (the default being "yes") 2) apply the patch 3) this time the "Memcached global configuration variables" section should point out that new instances will use memcached by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79481|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79603&action=edit Bug 21426: setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect Setting USE_MEMCACHED to "no" in /etc/koha/koha-sites.conf does not have any effect, because as of Bug 18342 memcached is enabled by default for new installations. With the proposed patch this potential source of confusion is removed from the configuration file. Test plan: 1) view koha-sites.conf and notice that you are given the option to set USE_MEMCACHED to either "yes" or "no" (the default being "yes") 2) apply the patch 3) this time the "Memcached global configuration variables" section should point out that new instances will use memcached by default Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am wondering if this is the right fix, I guess we should handle the "no" value instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79617&action=edit [ALTERNATIVE-PATCH] Bug 21426: Handle USE_MEMCACHED=no in koha-create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18342 | Status|Signed Off |In Discussion Depends on| |18342 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about this alternative patch? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 [Bug 18342] Set memcached as 'enabled' by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #6 from Andreas Roussos <arouss1980@gmail.com> --- (In reply to Jonathan Druart from comment #3)
I am wondering if this is the right fix, I guess we should handle the "no" value instead. Fine with me :-) FWIW my interpretation of the changes and comments in Bug 18342 was that it would no longer be possible to create an install without memcached, and I based my patch on that. I'll obsolete it now.
(In reply to Jonathan Druart from comment #5)
What about this alternative patch? Looks OK overall; is the echo bit above the if statement intentional?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79617|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79660&action=edit Bug 21426: Handle USE_MEMCACHED=no in koha-create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andreas Roussos from comment #6)
(In reply to Jonathan Druart from comment #5)
What about this alternative patch? Looks OK overall; is the echo bit above the if statement intentional?
Of course no, I amended the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #9 from Andreas Roussos <arouss1980@gmail.com> --- (In reply to Andreas Roussos from comment #0)
Oddly enough, once my instance was up and running I noticed that a memcached process had been started (Home > About Koha in the Staff interface also reported memcached as running). Actually, the memcached process had been there all along. The daemon is set to start automatically for runlevel 3 ('multi-user.target' in systemd-speak).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79660|0 |1 is obsolete| | --- Comment #10 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 79718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79718&action=edit Bug 21426: Handle USE_MEMCACHED=no in koha-create Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Works as intended. I've set USE_MEMCACHED to "no" and created a new Koha instance. Home > About now reports this information: Memcached: Servers: undefined | Namespace: undefined | Status: unknown | Config read from: Nowhere [...] | Effective caching method: Cache::Memory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79718|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80238&action=edit Bug 21426: Handle USE_MEMCACHED=no in koha-create Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Works as intended. I've set USE_MEMCACHED to "no" and created a new Koha instance. Home > About now reports this information: Memcached: Servers: undefined | Namespace: undefined | Status: unknown | Config read from: Nowhere [...] | Effective caching method: Cache::Memory Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18342 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org