[Bug 21389] New: Javascript error on article requests page bis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Bug ID: 21389 Summary: Javascript error on article requests page bis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 [Bug 21076] Javascript error on article requests page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Bug 21389 depends on bug 21076, which changed state. Bug 21076 Summary: Javascript error on article requests page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 79200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79200&action=edit Bug 21389: Correct Javascript error on article requests page Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input. Test plan: 1 - Do not apply patch 2 - Enable article requests 3 - Search on staff client and click 'Request article' 4 - Search for a patron that does not exist 5 - You get a yellow message "Patron not found" 6 - View error in console 7 - Apply patch 8 - Reload 9 - Not error is gone 10 - Search for a patron that does exist 11 - Check there is no error in console 12 - Check that autocompletion works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79200|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79226&action=edit Bug 21389: Correct Javascript error on article requests page Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input. Test plan: 1 - Do not apply patch 2 - Enable article requests 3 - Search on staff client and click 'Request article' 4 - Search for a patron that does not exist 5 - You get a yellow message "Patron not found" 6 - View error in console 7 - Apply patch 8 - Reload 9 - Not error is gone 10 - Search for a patron that does exist 11 - Check there is no error in console 12 - Check that autocompletion works Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am wondering what is best here: 1. Check in JS or 2. Keep the same TT conditionals (i.e. [% UNLESS no_patrons_found || patrons || patron %]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
I am wondering what is best here: 1. Check in JS or 2. Keep the same TT conditionals (i.e. [% UNLESS no_patrons_found || patrons || patron %])
For me it logical to prefer JS checks for a JS code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79226|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80247&action=edit Bug 21389: Correct Javascript error on article requests page Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input. Test plan: 1 - Do not apply patch 2 - Enable article requests 3 - Search on staff client and click 'Request article' 4 - Search for a patron that does not exist 5 - You get a yellow message "Patron not found" 6 - View error in console 7 - Apply patch 8 - Reload 9 - Not error is gone 10 - Search for a patron that does exist 11 - Check there is no error in console 12 - Check that autocompletion works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Javascript error on article |Javascript error on article |requests page bis |requests page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21389 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org