[Bug 43072] New: Hold policies display incorrectly in circ rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Bug ID: 43072 Summary: Hold policies display incorrectly in circ rules page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 41267 Target Milestone: --- Bug 41267 added a new hold policy type to the "Default holds and bookings policies by item type" section at the bottom of the page, "Fill other record level holds on record at checkout." If this policy is set to Yes or undefined, an item of the given itemtype can fill a bib-level hold even if the itemtype doesn't otherwise allow holds. If the policy is set to No, then the itemtype will not fill record-level holds. On upgrade, Bug 41267 does not set anything in the circulation_rules for this policy. After upgrade, any itemtype that has a value set for something else in this section will show a value of "No" for "Fill other record level holds on record at checkout" even though this policy isn't actually set. So the upgrade doesn't actually change any circ behavior, but it shows an erroneous change in the circ rules. To recreate: - be on a version of Koha without this code (25.11.04 or older) - set Hold Policy = "No holds allowed" for an itemtype - upgrade Koha to a version with this code - reload the circ rules page, confirm the Default holds and bookings policies by item type section still shows your Hold Policy value and *also* shows "Fill other record level holds on record at checkout" set to "No" for your itemtype - query "select * from circulation_rules where rule_name='fill_other_biblio_holds_policy'" and confirm no rule exists in the database - confirm a record-level hold can still be filled with an item of your itemtype - update your circ rules to actually save a No for "fill other record level holds" - confirm this now shows in your circ rules query - confirm a hold no longer fills It seems simplest to make this table show "Yes" when no policy exists. But on the other hand in current main I cannot set any rule in this table without also setting a "Fill other record level holds" value, so maybe it would be more consisten to actually save a "Yes" rule for 'fill_other_biblio_holds_policy' on any itemtype that already has something set for any other rule here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41267 [Bug 41267] It should be possible to prevent some itemtypes from filling other biblio level holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bywater@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201938&action=edit Bug 43072: Show Yes when no rule exists for fill_other_biblio_holds_policy To test 1 - have three test biblios. Bib A has just one item, a Book. Bib B has two items, a Book and a Computer File. Bib C has one item, a Computer File 2 - have KTD default circ rules (holds allowed for all itemtypes in the circ rules table, no values defined in "Default checkout, hold and return policy" or "Default holds and bookings policies by item type ") 3 - set "Default holds and bookings policies by item type" for Computer Files to Hold Policy = "No holds allowed." 4 - observe that "Fill other record level holds on record at checkout" defaults to "Yes" when a value is set to Hold Policy 5 - confirm you can place a holds on Bib A and Bib B but not Bib C 6 - confirm your hold on Bib B is filled when checking out the Computer File item from Bib B 7 - update "Default holds and bookings policies by item type" so Computer Files has Hold Policy = "No holds allowed" and "Fill other record level holds on record at checkout" = No 8 - confirm you're still able to place a hold on Bib B 9 - confirm your hold on Bib B is now *not* filled by checking out the Computer Files item 10 - open the commandline SQL interface (sudo koha-mysql kohadev on KTD) 11 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm an entry for Computer Files with rule_value=0 12 - run command "delete from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'" 13 - reload your circ rules page, confirm the interface still shows "Fill other record level holds on record at checkout" = No for comoputer files 14 - confirm your hold on Bib B can again be filled by checking out the Computer File item APPLY PATCH, restart_all 15 - reload circ rule page, confirm it now shows "Fill other record level holds on record at checkout" = Yes for Computer Files 16 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is still no entry for Computer Files 17 - place a new hold on Bib B, confirm it fills by checking out the Computer File (not having any rule defined is enforced the same as a "Yes" and displays a "Yes") 18 - in circ rules, set "Fill other record level holds on record at checkout" = Yes for computer files 19 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=1 20 - place a new hold on Bib B, confirm it fills by checking out the Computer File (having an explicit Yes rule defined is enforced correctly and displays correctly) 21 - in circ rules, set "Fill other record level holds on record at checkout" = No for computer files 22 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=0 23 - place a new hold on Bib B, confirm it does not fill by checking out the Computer File (having an explicit No rule defined is enforced correctly and displays correctly) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I went with the simpler solution -- create no new rules, but adjust the smart-rules.tt template to say "No" if the rule exists with a value of zero but otherwise say "Yes" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Dana Nicklas <dnicklas@waterfordtwplibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dnicklas@waterfordtwplibrar | |y.org --- Comment #3 from Dana Nicklas <dnicklas@waterfordtwplibrary.org> --- This bug is a pest! We can't place holds on video games...this makes our patrons kinda sad and makes my staff kinda stressed. If this bug could be exterminated it would be awesome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Dana Nicklas from comment #3)
This bug is a pest! We can't place holds on video games...this makes our patrons kinda sad and makes my staff kinda stressed. If this bug could be exterminated it would be awesome!
Dana, as I understand this bug it really should not be preventing your staff from placing holds. I suspect you're running into a separate issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 202889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202889&action=edit Bug 43072: (Bug 41267 follow-up) Add default rules when not set Bug 41267 defined the new rule, but didn't set the default. For consistencies sake we should create these in the DB To test: 1 - Create 'Default holds and bookings policies by item type' for two itemtypes Set 'Fill other record level holds on record at checkout' to yes for one and no for the other 2 - Apply this patch 3 - updatedatabase 4 - Verify the rules are not altered 5 - Chekc the DB: SELECT * FROM circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 6 - Note the number of rules/ids 7 - Run the DB update and confirm nothing changes 8 - DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy'; 9 - Run the DB update 10 - Confirm rules are replaced, both as yes 11 - Delete a single one of the rules now: DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy' AND id=#; 12 - Run the DB update 13 - Confirm only that rule is replaced 14 - DELETE from circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 15 - Run the DB update 16 - No new rules are created follo# Koha/.Patrons.pm.swp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #6 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 202928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202928&action=edit Bug 43072: (Bug 41267 follow-up) Add default rules when not set Bug 41267 defined the new rule, but didn't set the default. For consistencies sake we should create these in the DB To test: 1 - Create 'Default holds and bookings policies by item type' for two itemtypes Set 'Fill other record level holds on record at checkout' to yes for one and no for the other 2 - Apply this patch 3 - updatedatabase 4 - Verify the rules are not altered 5 - Chekc the DB: SELECT * FROM circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 6 - Note the number of rules/ids 7 - Run the DB update and confirm nothing changes 8 - DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy'; 9 - Run the DB update 10 - Confirm rules are replaced, both as yes 11 - Delete a single one of the rules now: DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy' AND id=#; 12 - Run the DB update 13 - Confirm only that rule is replaced 14 - DELETE from circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 15 - Run the DB update 16 - No new rules are created follo# Koha/.Patrons.pm.swp Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loreganlloyd@clamsnet.org --- Comment #7 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Code seems to work as expected! I imagine the boilerplate from skeleton.pl will need to be filled out before passing QA, though? bug_number => "BUG_NUMBER", description => "A single line description", # Do you stuffs here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lawrence O'Regan-Lloyd from comment #7)
Code seems to work as expected! I imagine the boilerplate from skeleton.pl will need to be filled out before passing QA, though?
bug_number => "BUG_NUMBER", description => "A single line description", # Do you stuffs here
That's correct, setting to FQA to alert dev. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 202975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202975&action=edit Bug 43072: standardize atomicupdate formatting Patch from commit b0152f1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thank you both! I've corrected the atomicupdate, setting this back to Signed Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold policies display |fill_other_biblio_holds_pol |incorrectly in circ rules |icy values display |page |incorrectly in circ rules | |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 204380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204380&action=edit Bug 43072: Show Yes when no rule exists for fill_other_biblio_holds_policy To test 1 - have three test biblios. Bib A has just one item, a Book. Bib B has two items, a Book and a Computer File. Bib C has one item, a Computer File 2 - have KTD default circ rules (holds allowed for all itemtypes in the circ rules table, no values defined in "Default checkout, hold and return policy" or "Default holds and bookings policies by item type ") 3 - set "Default holds and bookings policies by item type" for Computer Files to Hold Policy = "No holds allowed." 4 - observe that "Fill other record level holds on record at checkout" defaults to "Yes" when a value is set to Hold Policy 5 - confirm you can place a holds on Bib A and Bib B but not Bib C 6 - confirm your hold on Bib B is filled when checking out the Computer File item from Bib B 7 - update "Default holds and bookings policies by item type" so Computer Files has Hold Policy = "No holds allowed" and "Fill other record level holds on record at checkout" = No 8 - confirm you're still able to place a hold on Bib B 9 - confirm your hold on Bib B is now *not* filled by checking out the Computer Files item 10 - open the commandline SQL interface (sudo koha-mysql kohadev on KTD) 11 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm an entry for Computer Files with rule_value=0 12 - run command "delete from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'" 13 - reload your circ rules page, confirm the interface still shows "Fill other record level holds on record at checkout" = No for comoputer files 14 - confirm your hold on Bib B can again be filled by checking out the Computer File item APPLY PATCH, restart_all 15 - reload circ rule page, confirm it now shows "Fill other record level holds on record at checkout" = Yes for Computer Files 16 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is still no entry for Computer Files 17 - place a new hold on Bib B, confirm it fills by checking out the Computer File (not having any rule defined is enforced the same as a "Yes" and displays a "Yes") 18 - in circ rules, set "Fill other record level holds on record at checkout" = Yes for computer files 19 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=1 20 - place a new hold on Bib B, confirm it fills by checking out the Computer File (having an explicit Yes rule defined is enforced correctly and displays correctly) 21 - in circ rules, set "Fill other record level holds on record at checkout" = No for computer files 22 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=0 23 - place a new hold on Bib B, confirm it does not fill by checking out the Computer File (having an explicit No rule defined is enforced correctly and displays correctly) Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 204381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204381&action=edit Bug 43072: (Bug 41267 follow-up) Add default rules when not set Bug 41267 defined the new rule, but didn't set the default. For consistencies sake we should create these in the DB To test: 1 - Create 'Default holds and bookings policies by item type' for two itemtypes Set 'Fill other record level holds on record at checkout' to yes for one and no for the other 2 - Apply this patch 3 - updatedatabase 4 - Verify the rules are not altered 5 - Chekc the DB: SELECT * FROM circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 6 - Note the number of rules/ids 7 - Run the DB update and confirm nothing changes 8 - DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy'; 9 - Run the DB update 10 - Confirm rules are replaced, both as yes 11 - Delete a single one of the rules now: DELETE from circulation_rules WHERE rule_name='fill_other_biblio_holds_policy' AND id=#; 12 - Run the DB update 13 - Confirm only that rule is replaced 14 - DELETE from circulation_rules WHERE branchcode IS NULL and categorycode IS NULL; 15 - Run the DB update 16 - No new rules are created follo# Koha/.Patrons.pm.swp Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 204382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204382&action=edit Bug 43072: standardize atomicupdate formatting Signed-off-by: Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #14 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 204383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204383&action=edit Bug 43072: (QA follow-up) Use say_info in dbrev Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org