https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bywater@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43072 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201938&action=edit Bug 43072: Show Yes when no rule exists for fill_other_biblio_holds_policy To test 1 - have three test biblios. Bib A has just one item, a Book. Bib B has two items, a Book and a Computer File. Bib C has one item, a Computer File 2 - have KTD default circ rules (holds allowed for all itemtypes in the circ rules table, no values defined in "Default checkout, hold and return policy" or "Default holds and bookings policies by item type ") 3 - set "Default holds and bookings policies by item type" for Computer Files to Hold Policy = "No holds allowed." 4 - observe that "Fill other record level holds on record at checkout" defaults to "Yes" when a value is set to Hold Policy 5 - confirm you can place a holds on Bib A and Bib B but not Bib C 6 - confirm your hold on Bib B is filled when checking out the Computer File item from Bib B 7 - update "Default holds and bookings policies by item type" so Computer Files has Hold Policy = "No holds allowed" and "Fill other record level holds on record at checkout" = No 8 - confirm you're still able to place a hold on Bib B 9 - confirm your hold on Bib B is now *not* filled by checking out the Computer Files item 10 - open the commandline SQL interface (sudo koha-mysql kohadev on KTD) 11 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm an entry for Computer Files with rule_value=0 12 - run command "delete from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'" 13 - reload your circ rules page, confirm the interface still shows "Fill other record level holds on record at checkout" = No for comoputer files 14 - confirm your hold on Bib B can again be filled by checking out the Computer File item APPLY PATCH, restart_all 15 - reload circ rule page, confirm it now shows "Fill other record level holds on record at checkout" = Yes for Computer Files 16 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is still no entry for Computer Files 17 - place a new hold on Bib B, confirm it fills by checking out the Computer File (not having any rule defined is enforced the same as a "Yes" and displays a "Yes") 18 - in circ rules, set "Fill other record level holds on record at checkout" = Yes for computer files 19 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=1 20 - place a new hold on Bib B, confirm it fills by checking out the Computer File (having an explicit Yes rule defined is enforced correctly and displays correctly) 21 - in circ rules, set "Fill other record level holds on record at checkout" = No for computer files 22 - run query "select * from circulation_rules where rule_name = 'fill_other_biblio_holds_policy'"; confirm there is an entry for Computer Files with rule_value=0 23 - place a new hold on Bib B, confirm it does not fill by checking out the Computer File (having an explicit No rule defined is enforced correctly and displays correctly) -- You are receiving this mail because: You are watching all bug changes.