https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | Depends on| |10817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 [Bug 10817] SIPserver does not return holds info when requested -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #0)

I can't find good documentation on this, but I think this is a bug:

hold_items => $flags->{WAITING}->{itemlist},

holds_items is currently a count of waiting holds, when it should total holds.

Meanwhile unavail_holds is a count of all holds except waiting holds.

Some 3rd party SIP machines use this calculation to get a count of "holds to pick up":

holds ready for pickup = hold_items - unavail_holds

Currently this can produce a negative number.

Bug 10817 seems to confirm this is a bug: Sip devices need this to show to the user what books they have on hold and what holds they have awaiting collection. The SIP2 protocol spec also seems to agree ( but not explicitly ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199618&action=edit Bug 42700: hold_items in SIP patron info should contain all holds, not just waiting Some 3rd party SIP clients calculate the number of holds ready for pickup as: holds ready for pickup = hold_items - unavail_holds Right now this can produce a negative number since hold_items contains only waiting holds. This patch makes hold_items contain all of the patron's holds, so hold_items - unavail_holds correctly gives the count of holds ready to be picked up. Test Plan: 1) Apply the first patch only 2) prove t/db_dependent/SIP/Patron.t 3) Note the new "hold_items counts all holds" subtest fails 4) Apply this patch 5) prove t/db_dependent/SIP/Patron.t 6) Note the tests pass! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199620&action=edit Bug 42700: Remove dead $flags->{WAITING} code from C4::Members::patronflags After the previous patch, $flags->{WAITING} from C4::Members::patronflags is no longer read anywhere in Koha. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/ t/db_dependent/Members.t 3) Note all tests pass! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199617|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 199636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199636&action=edit Bug 42700: Add unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42700 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 199638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199638&action=edit Bug 42700: Avoid duplicate holds query query when building SIP patron object This patch fetches the patron's holds once into a list of Koha::Hold objects and derives both hold_items and unavail_holds from that single fetch. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/ 3) Note all tests pass! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.