[Bug 20588] New: Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Bug ID: 20588 Summary: Elasticsearch - Apply dataTable on search fields and mapping tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com Apply dataTable on search fields and mapping tables to be able to sort and filter data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74241&action=edit Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 [Bug 20388] Elasticsearch - Ability to add search fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Hiya Alex, Applying: Bug 20588 - Apply dataTable on search fields and mapping tables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Nicolas Legrand from comment #2)
Hiya Alex,
Applying: Bug 20588 - Apply dataTable on search fields and mapping tables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/ mappings.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping tables
Hello Nicolas, Did you apply in order: 18316 and 20388 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #4 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- I applied it with Jonathan autoapply : $ git bz apply 20588 Bug 20588 Depends on bug 20388 Follow? [(y)es, (n)o] y Bug 20388 Depends on bug 18316 Follow? [(y)es, (n)o] y Bug 18316 - Add weighting/relevancy options to ElasticSearch 74115 - Bug 18316: Ability to weight search fields 74116 - Bug 18316: Add weighting/relevancy options to ES query on simple search 74117 - Bug 18316: String changes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18316: Ability to weight search fields Applying: Bug 18316: Add weighting/relevancy options to ES query on simple search Applying: Bug 18316: String changes Bug 20388 - Elasticsearch - Ability to add search fields from UI 73945 - Bug 20388 - Add/delete search fields from search engine configuration page 73946 - Bug 20388 - Keep data consistency when adding/removing mapping 74261 - Bug 11674: DBRev 17.12.00.031 Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20388 - Add/delete search fields from search engine configuration page Applying: Bug 20388 - Keep data consistency when adding/removing mapping Applying: Bug 11674: DBRev 17.12.00.031 Using index info to reconstruct a base tree... M Koha.pm A installer/data/mysql/atomicupdate/bug_11674-config_for_marc_field_doc_urls.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... No changes -- Patch already applied. Bug 20588 - Elasticsearch - Apply dataTable on search fields and mapping tables 74241 - Bug 20588 - Apply dataTable on search fields and mapping tables Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20588 - Apply dataTable on search fields and mapping tables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74241|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74312&action=edit Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- I've rebased the patch. Please try again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like this patch removes the ability to sort the table (plugin tablednd), and store this order in DB. Are you sure we do no longer need that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74312|0 |1 is obsolete| | --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74315&action=edit Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Jonathan has an other view of the patch. As user, it looks pretty good to me ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #7)
Looks like this patch removes the ability to sort the table (plugin tablednd), and store this order in DB. Are you sure we do no longer need that?
This patch exactly add the ability to sort tables columns. And, if i understand what you are talking about, we don't lose the drag and drop feature provided by tableDnD plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorting by user's preference I meant, not sorting by alpha/num Moreover the drag and drop functionality does not longer work after one of the column has been sorted. I do not remember if this is used, could be useful later, or totally useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |BLOCKED --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Changing status to BLOCKED, as it depends on 20388, which needs a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74315|0 |1 is obsolete| | --- Comment #13 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78660&action=edit Bug 20588 - Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- BLOCKED by bug 20338 dependency being Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #14)
BLOCKED by bug 20338 dependency being Needs Signoff.
Should be BLOCKED by bug 20388 - which is signed off now, so unlocking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by dependency bug 20388 awaiting sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #17 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 90576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90576&action=edit Bug 20588: Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar@biblibre.com Attachment #78660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #18 from axel Amghar <axel.amghar@biblibre.com> --- I just made a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 --- Comment #19 from axel Amghar <axel.amghar@biblibre.com> --- *** Bug 19598 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 [Bug 22639] Elasticsearch ability export mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 [Bug 22994] Elasticsearch ability import mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90576|0 |1 is obsolete| | --- Comment #20 from Michal Denar <black23@gmail.com> --- Created attachment 90585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90585&action=edit Bug 20588: Apply dataTable on search fields and mapping tables This add the following capabilities: - Pagination, - columns sorting, - data filtering Test plan: - apply this patch, - update DB and schema files, - add/remove search fields and mappings Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching - Elasticsearch |Templates Status|Signed Off |BLOCKED QA Contact| |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27316 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35265 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|BLOCKED |RESOLVED --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 27682 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Bug 20588 depends on bug 20388, which changed state. Bug 20388 Summary: Ability to add search fields from UI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org