[Bug 20388] New: Elasticsearch - Ability to add index from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bug ID: 20388 Summary: Elasticsearch - Ability to add index from UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com Currently indexes only coming from mapping.yaml. We need to add some using UI (admin/searchengine/elasticsearch/mappings.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud@biblibre.com | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #1 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- * The add line could be at the begin of the page. * A delete button could be on each line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73158&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73158|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73165&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73165|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73167&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- This new feature will be very useful ! It also makes the "Search fields" tab clearer, for we now can see which index are unused. Thanks Alex ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- *** Bug 18194 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73167|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73476&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. What's the point of the JS function valid_line? I think you should double-check it, it does not do what you expect it to do. 2. You are reusing code to duplicate a new mapping but for something else. You should rename the variables to avoid confusion then. For instance "search_fields" is not an index name 3. Bug report's title is wrong, we are not adding/removing indices 4. I did not implement that part on the original patch because it's hard to keep an interface consistent. For instance: - create a new search field => You cannot create a new mapping, you have to save first - create a new search field, save => You can delete it. So it you create a mapping using it, you can still delete it. If you save => kaboom => If you have a search field already mapped and delete the mapping, you cannot delete the search field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #8) > 1. What's the point of the JS function valid_line? > I think you should double-check it, it does not do what you expect it to do. > > 2. You are reusing code to duplicate a new mapping but for something else. > You should rename the variables to avoid confusion then. > For instance "search_fields" is not an index name I wanted to reuse the code as much as possible. It is not a problem for to add a js fonction dedicated to duplicate search fields only. > > 3. Bug report's title is wrong, we are not adding/removing indices Right! > > 4. I did not implement that part on the original patch because it's hard to > keep an interface consistent. > For instance: > - create a new search field > => You cannot create a new mapping, you have to save first > - create a new search field, save > => You can delete it. So it you create a mapping using it, you can still > delete it. If you save => kaboom > => If you have a search field already mapped and delete the mapping, you > cannot delete the search field. I see 2 solutions: 1) JS code for validating data when saving and warn the user if there is something inconsistent. May be quite tricky... 2) Submit the form on clicking the "+add" button. There is a disavantage: page is reloaded between each adding. Not confortable for adding many search fields or mapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - Ability to |Elasticsearch - Ability to |add index from UI |add search fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73476|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73626&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73627&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - you create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (don't save) - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73627|0 |1 is obsolete| | --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73629&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authoroties), don't save, - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73626|0 |1 is obsolete| | --- Comment #13 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73681&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73629|0 |1 is obsolete| | --- Comment #14 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73682&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8)
1. What's the point of the JS function valid_line? I think you should double-check it, it does not do what you expect it to do.
You forgot that point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #15)
(In reply to Jonathan Druart from comment #8)
1. What's the point of the JS function valid_line? I think you should double-check it, it does not do what you expect it to do.
You forgot that point.
I removed that function. Not esasy to see since i squashed this operation in the first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed, thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73681|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73918&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73682|0 |1 is obsolete| | --- Comment #19 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73919&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 [Bug 18316] Add weighting/relevancy options to ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #20 from Alex Arnaud <alex.arnaud@biblibre.com> --- Made this BZ depends on 18316 because i'm reusing a subroutine created in. So put this one back on needs signoff to be sure nothing is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73918|0 |1 is obsolete| | --- Comment #21 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73940&action=edit Bug 18316 - Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73918|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73918|0 |1 is obsolete| | --- Comment #22 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73943&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73919|0 |1 is obsolete| | --- Comment #23 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73944&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73943|0 |1 is obsolete| | --- Comment #24 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73945&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73944|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73946&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I tested this one (when reviewing bug 18316). We can have inconsistency when using the UI: - Add acqdate to authority - Add weight to acqdate for biblio - Save - Remove it for biblio - Save => weight is still set in DB but not displayed on the UI It's not that important, because not used. But if we continue that way we are going to have a lot of inconsistencies. I built this interface (bug 14899, 2.5 years ago) as an example. Now we are going to add lot of information and maybe we should rethink the interface. I can easily imagine somebody spending 2 hours switching from 1 tab to another and modifying everything, then finally save, and... everything is lost because an error occurred. It seems obvious that the search fields form should be a separate page to force a save before modifying the mappings. Maybe better would be to save via AJAX when the tab is changed (or force the user to save), and refresh the new tab to have updated info. The "add" and "delete" buttons could also send AJAX requests. I do not think it will be blocker for 18.05, but keep this comment in mind if you plan to add more and more stuffs to this view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would also has been fair to base your patches on top of the other ones in the queue (since 1 year), bug 18235 for instance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #28 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74261&action=edit Bug 11674: DBRev 17.12.00.031 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #29 from Séverine Queune <severine.queune@bulac.fr> --- Something weird happened when I signed it.. Sorry about that. Behaviour is ok for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74261|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73945|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74718&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73946|0 |1 is obsolete| | --- Comment #31 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74719&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |joonas.kylmala@helsinki.fi --- Comment #32 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I was trying to test these patches but they don't apply on top of latest master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74718|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78658&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74719|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78659&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- There is a little problem that needs to be fixed: 1. Add a search field, save 2. Delete the search field, don't save 3. Go to "Bibliographic records" tab, add a new mapping for this search field, Save. 4. An error message appear:
An error occurred when updating mappings (Can't call method "add_to_search_marc_maps" on an undefined value at /home/koha/env/master/src/admin/searchengine/elasticsearch/mappings.pl line 107. ).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #36 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80709&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bug 20388 depends on bug 18316, which changed state. Bug 18316 Summary: Add weighting/relevancy options to ElasticSearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #34)
Created attachment 78659 [details] [review] Bug 20388 - Keep data consistency when adding/removing mapping
Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field.
- delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field.
This does not work, first part is OK, but in second one, I still can't remove the searchfield... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #38 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Josef Moravec from comment #37)
(In reply to Alex Arnaud from comment #34)
Created attachment 78659 [details] [review] [review] Bug 20388 - Keep data consistency when adding/removing mapping
Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field.
- delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field.
This does not work, first part is OK, but in second one, I still can't remove the searchfield...
Hello, You mean you deleted all mapping related to a search field and you can delete it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #39 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Alex Arnaud from comment #38)
(In reply to Josef Moravec from comment #37)
(In reply to Alex Arnaud from comment #34)
Created attachment 78659 [details] [review] [review] [review] Bug 20388 - Keep data consistency when adding/removing mapping
Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field.
- delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field.
This does not work, first part is OK, but in second one, I still can't remove the searchfield...
Hello,
You mean you deleted all mapping related to a search field and you can delete it ?
Works for me... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #40 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Hi! We also tested the patch and can't remove the search field according to your instructions. If I save the mappings first it works ok. Tested in FF and Chrome After a quick look it seems the newly created mappings is missing the onclick event to enable the delete button on the search field-tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #41 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86912&action=edit Bug 20388: Use live handler for deleting elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #42 from Björn Nylén <bjorn.nylen@ub.lu.se> --- The patch doesnt apply for me on the current master. Applying: Bug 20388 - Add/delete search fields from search engine configuration page fatal: sha1 information is lacking or useless (admin/searchengine/elasticsearch/mappings.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20388 - Add/delete search fields from search engine configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78658|0 |1 is obsolete| | --- Comment #43 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 87196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87196&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78659|0 |1 is obsolete| | --- Comment #44 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 87197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87197&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80709|0 |1 is obsolete| | --- Comment #45 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 87198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87198&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86912|0 |1 is obsolete| | --- Comment #46 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 87199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87199&action=edit Bug 20388: Use live handler for deleting elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87196|0 |1 is obsolete| | --- Comment #47 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 87201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87201&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87197|0 |1 is obsolete| | --- Comment #48 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 87202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87202&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87198|0 |1 is obsolete| | --- Comment #49 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 87203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87203&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87199|0 |1 is obsolete| | --- Comment #50 from Björn Nylén <bjorn.nylen@ub.lu.se> --- Created attachment 87204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87204&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 87201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87201 Bug 20388 - Add/delete search fields from search engine configuration page Review of attachment 87201: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20388&attachment=87201) ----------------------------------------------------------------- ::: admin/searchengine/elasticsearch/mappings.pl @@ +217,5 @@
my $search_field_unblessed = $search_field->unblessed; $search_field_unblessed->{mapped_biblios} = 1 if $search_field->is_mapped_biblios; + + $search_field_unblessed->{is_mapped} = $schema->resultset('SearchMarcToField')->search( + { search_field_id => $search_field->id })->count;
Can be replaced by $search_field_unblessed->{is_mapped} = $search_field->is_mapped; But why is it unblessed in the first place, and not directly passed to template ? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ +64,5 @@
+ var name = $(line).find('input[data-id="search_field_name"]').val(); + var label = $(line).find('input[data-id="search_field_name"]').val(); + if ( name.length > 0 && label.length > 0 ) { + var new_line = clone_line( line ); + new_line.appendTo($('table[data-index_name=search_fields]>tbody'));
You should probably use the already existing 'table' variable instead of searching in the whole DOM @@ +72,5 @@
+ clean_line(line); + + $(table).tableDnD( { + onDragClass: "dragClass", + } );
This is weird. Drag and Drop is not enabled on this table until you add a new field. And it looks like it is useless to move lines around since they are automatically ordered alphabetically after a save @@ +242,5 @@
+ [% IF search_field.is_mapped %] + <a class="btn btn-default btn-xs disabled delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> + [% ELSE %] + <a class="btn btn-default btn-xs delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> + [% END %]
It might be better to use a <button> here to avoid the inline style, and to use the disabled attribute instead of the disabled class @@ +244,5 @@
+ [% ELSE %] + <a class="btn btn-default btn-xs delete" style="cursor: pointer;"><i class="fa fa-trash"></i> Delete</a> + [% END %] + </td> + </td>
Double end tag, should be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 87203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87203 Bug 20388: Prevent user from using a search field for a mapping after removing it Review of attachment 87203: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20388&attachment=87203) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ +33,4 @@
var line = $(this).closest("tr"); + + // We clicked delete button on search fields tab. + if (name = $(line).find('input[name="search_field_name"]').val()) {
It looks like 'name' is a global variable. Declare it with 'var' to avoid that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #53 from Julian Maurice <julian.maurice@biblibre.com> --- Additional QA comments: - I noticed a strange behaviour. After resetting all mappings ("Reset mappings" button), all "Delete" buttons are disabled until I click on "Save". What is happening here ? - If I add a new field with the same name of an existing field, and move the line to the top, the existing field will be deleted and the new field will remain. It could be a problem if the types differ. There should be a control to avoid that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #54 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88075&action=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87201|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 88079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88079&action=edit Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87202|0 |1 is obsolete| | --- Comment #56 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 88080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88080&action=edit Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87203|0 |1 is obsolete| | --- Comment #57 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 88081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88081&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87204|0 |1 is obsolete| | --- Comment #58 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 88082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88082&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88075|0 |1 is obsolete| | --- Comment #59 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 88083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88083&action=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- If i add a field and then add a mapping, then delete the mapping, I am unable to the delete the field I poked the DB a bit - it looks like the numberings are getting mixed up somewhere/somehow The ids for search_field are rebuilt on every save? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are we still hoping to move this along for 19.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #62 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Martin Renvoize from comment #61)
Are we still hoping to move this along for 19.05?
We (Biblibre) will send some fixes very soon. Work in progress... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #63 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89117&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89117|0 |1 is obsolete| | --- Comment #64 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89118&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar@biblibre.com Attachment #89118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #65 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89121&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #66 from Liz Rea <wizzyrea@gmail.com> --- Hi, I've just tried to test this, and I don't see the row at the bottom to add new mappings on the search tab? Terribly sorry, I'm quite sure I restarted the things and did all of the prerequisites, but as usual not sure if it was something I'm doing wrong or if it's the code. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #67 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Liz Rea from comment #66)
Hi,
I've just tried to test this, and I don't see the row at the bottom to add new mappings on the search tab?
Terribly sorry, I'm quite sure I restarted the things and did all of the prerequisites, but as usual not sure if it was something I'm doing wrong or if it's the code.
Cheers, Liz
Hi, Are you sure you are at the good place? You can add search fields at the biottom of the search field part, but to add new mappings you have to go at the bottom of bibliographic records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #68 from Alex Arnaud <alex.arnaud@biblibre.com> --- Anyone else can reproduce Liz's issue ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #69 from Liz Rea <wizzyrea@gmail.com> --- there were no entry boxes at the bottom of either tab, sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #70 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Liz Rea from comment #69)
there were no entry boxes at the bottom of either tab, sorry.
If you realy are in search engine configuration. Remove the patch, so you should be in master. - return to search engine configuration - go to bibliographic records or authorities - at the bottom of the tab, you should see the add line because this patch just add the line at the bottom of search field - if you don't, there is a issue on your side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The new "add" line appears for me, but the "Type" dropdown does not contain the same values as above. Please double check. In case of misunderstanding it's always good to share a screenshot, so here it is: https://snag.gy/2XiGEd.jpg # Scroll down! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also, if you add a field that already exists, it is ignored (no warning, no updated). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #73 from Liz Rea <wizzyrea@gmail.com> --- Re-checked this today, and the fields showed up. Quite sure I didn't do anything differently, sorry for the noise. As Jonathan noted, the types for the new entries don't match with the types in the existing entries. Is that intentional? When I tested adding a name and label that already existed, it added it for me - I don't know if that is correct or incorrect behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #74 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89733&action=edit Bug 20388: add of types in the new entries dropdown of searchfiels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #75 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Liz Rea from comment #73)
Re-checked this today, and the fields showed up. Quite sure I didn't do anything differently, sorry for the noise.
As Jonathan noted, the types for the new entries don't match with the types in the existing entries. Is that intentional?
When I tested adding a name and label that already existed, it added it for me - I don't know if that is correct or incorrect behaviour.
Hi, I fix the types for the new entries ( I don't think it was intentional). But for the adding, I didn't succeed to reproduce your bug. How did you do it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #75 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Liz Rea from comment #73)
Re-checked this today, and the fields showed up. Quite sure I didn't do anything differently, sorry for the noise.
As Jonathan noted, the types for the new entries don't match with the types in the existing entries. Is that intentional?
When I tested adding a name and label that already existed, it added it for me - I don't know if that is correct or incorrect behaviour.
Hi, I fix the types for the new entries ( I don't think it was intentional). But for the adding, I didn't succeed to reproduce your bug. How did you do it? --- Comment #76 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Liz Rea from comment #73)
Re-checked this today, and the fields showed up. Quite sure I didn't do anything differently, sorry for the noise.
As Jonathan noted, the types for the new entries don't match with the types in the existing entries. Is that intentional?
When I tested adding a name and label that already existed, it added it for me - I don't know if that is correct or incorrect behaviour.
Hi, I fix the types for the new entries ( I don't think it was intentional). But for the adding, I didn't succeed to reproduce your bug. How did you do it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Like that, adding a new 'uri' field: https://snag.gy/BpxcIq.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #78 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89894&action=edit Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88079|0 |1 is obsolete| | Attachment #88080|0 |1 is obsolete| | Attachment #88081|0 |1 is obsolete| | Attachment #88082|0 |1 is obsolete| | Attachment #88083|0 |1 is obsolete| | Attachment #89121|0 |1 is obsolete| | Attachment #89733|0 |1 is obsolete| | Attachment #89894|0 |1 is obsolete| | --- Comment #79 from Michal Denar <black23@gmail.com> --- Created attachment 90517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90517&action=edit Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #80 from Michal Denar <black23@gmail.com> --- Created attachment 90518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90518&action=edit Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #81 from Michal Denar <black23@gmail.com> --- Created attachment 90519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90519&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #82 from Michal Denar <black23@gmail.com> --- Created attachment 90520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90520&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #83 from Michal Denar <black23@gmail.com> --- Created attachment 90521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90521&action=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #84 from Michal Denar <black23@gmail.com> --- Created attachment 90522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90522&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #85 from Michal Denar <black23@gmail.com> --- Created attachment 90523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90523&action=edit Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #86 from Michal Denar <black23@gmail.com> --- Created attachment 90524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90524&action=edit Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20589 Status|Signed Off |ASSIGNED QA Contact| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 anne-cecile.bories@iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories@iepg.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90517|0 |1 is obsolete| | --- Comment #87 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98011&action=edit Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90518|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98012&action=edit Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90519|0 |1 is obsolete| | --- Comment #89 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98013&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90520|0 |1 is obsolete| | --- Comment #90 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98014&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90521|0 |1 is obsolete| | --- Comment #91 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98015&action=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90522|0 |1 is obsolete| | --- Comment #92 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98016&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90523|0 |1 is obsolete| | --- Comment #93 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98017&action=edit Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90524|0 |1 is obsolete| | --- Comment #94 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 98018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98018&action=edit Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #95 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patches have been rebased on upon bug 19482 which prevent removing mandatory fields. So set back to need signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 [Bug 19482] Elasticsearch - prevent removal / editing of required indexes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98011|0 |1 is obsolete| | Attachment #98012|0 |1 is obsolete| | Attachment #98013|0 |1 is obsolete| | Attachment #98014|0 |1 is obsolete| | Attachment #98015|0 |1 is obsolete| | Attachment #98016|0 |1 is obsolete| | Attachment #98017|0 |1 is obsolete| | Attachment #98018|0 |1 is obsolete| | --- Comment #96 from Michal Denar <black23@gmail.com> --- Created attachment 99960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99960&action=edit Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #97 from Michal Denar <black23@gmail.com> --- Created attachment 99961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99961&action=edit Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #98 from Michal Denar <black23@gmail.com> --- Created attachment 99962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99962&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #99 from Michal Denar <black23@gmail.com> --- Created attachment 99963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99963&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #100 from Michal Denar <black23@gmail.com> --- Created attachment 99964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99964&action=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #101 from Michal Denar <black23@gmail.com> --- Created attachment 99965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99965&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #102 from Michal Denar <black23@gmail.com> --- Created attachment 99966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99966&action=edit Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #103 from Michal Denar <black23@gmail.com> --- Created attachment 99967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99967&action=edit Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This depends on bug 19482 which is currently Failed QA. Marking as BLOCKED until this is resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |fridolin.somers@biblibre.co | |m --- Comment #105 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- bug 19482 is pushed master, I reset to previous status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #106 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK for QA ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #107 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Created attachment 119296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119296&action=edit Issue #6 - Restore continue, skip and abort -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Gérard Simon Voyer <simon.voyer@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.voyer@collecto.ca --- Comment #108 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- (In reply to Gérard Simon Voyer from comment #107)
Created attachment 119296 [details] [review] Issue #6 - Restore continue, skip and abort
All the Saints in the World, what have I done?? This is completely unintentional, I will cease right now my tinkering with git-bz and just apply patches the like I used to. Please forgive this dumb mistake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119296|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #109 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Gérard Simon Voyer from comment #108)
(In reply to Gérard Simon Voyer from comment #107)
Created attachment 119296 [details] [review] [review] Issue #6 - Restore continue, skip and abort
All the Saints in the World, what have I done?? This is completely unintentional, I will cease right now my tinkering with git-bz and just apply patches the like I used to.
Please forgive this dumb mistake
Don't worry Gérard, i marked your patch as obsolete. No consequence -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99960|0 |1 is obsolete| | Attachment #99961|0 |1 is obsolete| | Attachment #99962|0 |1 is obsolete| | Attachment #99963|0 |1 is obsolete| | Attachment #99964|0 |1 is obsolete| | Attachment #99965|0 |1 is obsolete| | Attachment #99966|0 |1 is obsolete| | Attachment #99967|0 |1 is obsolete| | --- Comment #110 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 119317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119317&action=edit Bug 20388 - Elasticsearch - Ability to add search fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119317|0 |1 is obsolete| | --- Comment #111 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 119318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119318&action=edit Bug 20388 - Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #112 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patches rebased and squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #113 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- What a great way for me to say "Hey, I'm the new in-house dev for Collecto's version of Koha!" Thanks again, I swear next time I have to break something, it'll be much more impressive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry chaps, this one no longer applies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #115 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Is there any way to apply this functionnality on top of the master branch as of now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119318|0 |1 is obsolete| | --- Comment #116 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 120104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120104&action=edit Bug 20388 - Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #117 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patch rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Needs Signoff, again? How was the rebase Alex? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #119 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #118)
Needs Signoff, again? How was the rebase Alex?
The last one was tiny. But the one 2 weeks ago was tricky. A new signoff wouldn't be too much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #120 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Hi Alex! I'm trying my hand at sign offs. On a koha-docker-testing CT using master branch, I seem to fall on this error upon entering the ElasticSearch mappings setup : https://pastebin.com/8Mj7LzvM Something I'm doing wrong? I remember this message being addressed in one of the obsoleted patches. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Gérard Simon Voyer from comment #120)
Hi Alex!
I'm trying my hand at sign offs. On a koha-docker-testing CT using master branch, I seem to fall on this error upon entering the ElasticSearch mappings setup : https://pastebin.com/8Mj7LzvM
Something I'm doing wrong? I remember this message being addressed in one of the obsoleted patches.
Thanks a lot!
Hi, you can try Actions > Refresh Schema to see if this fixes the issue. An Actions > Restart services also sometimes doesn't hurt (restarts Plack, Memcached, Apache etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bug 20388 depends on bug 19482, which changed state. Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #122 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. git bz apply 20388 Bug 20388 - Elasticsearch - Ability to add search fields from UI 120104 - Bug 20388 - Elasticsearch - Ability to add search fields from UI Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20388 - Elasticsearch - Ability to add search fields from UI Using index info to reconstruct a base tree... M Koha/SearchField.pm M admin/searchengine/elasticsearch/mappings.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt M koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging admin/searchengine/elasticsearch/mappings.pl Auto-merging Koha/SearchField.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20388 - Elasticsearch - Ability to add search fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just ran into this again - especially with us not updating the default mappings on update it would be important to allow libraries to add indexes i think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #124 from Michaela Sieber <michaela.sieber@kit.edu> --- Is it possible to rebase? It seems that many libraries and support providers are interested. And a lot of work has already been done, it would be a pity if it did not continue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120104|0 |1 is obsolete| | --- Comment #125 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163449&action=edit Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #126 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163450&action=edit Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #127 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163451&action=edit Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #128 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163452&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud@biblibre.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163449|0 |1 is obsolete| | --- Comment #129 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 163460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163460&action=edit Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163450|0 |1 is obsolete| | --- Comment #130 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 163461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163461&action=edit Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163451|0 |1 is obsolete| | --- Comment #131 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 163462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163462&action=edit Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163452|0 |1 is obsolete| | --- Comment #132 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 163463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163463&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |lukasz.koszyk@kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 [Bug 35138] Elasticsearch - manage facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163463|0 |1 is obsolete| | --- Comment #133 from Thomas Klausner <domm@plix.at> --- Created attachment 164529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164529&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 davewood@gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164529|0 |1 is obsolete| | --- Comment #134 from davewood@gmx.at --- Created attachment 164530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164530&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164530|0 |1 is obsolete| | --- Comment #135 from Thomas Klausner <domm@plix.at> --- Created attachment 164531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164531&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 davewood@gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163460|0 |1 is obsolete| | --- Comment #136 from davewood@gmx.at --- Created attachment 164532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164532&action=edit Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 davewood@gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163461|0 |1 is obsolete| | --- Comment #137 from davewood@gmx.at --- Created attachment 164533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164533&action=edit Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 davewood@gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163462|0 |1 is obsolete| | --- Comment #138 from davewood@gmx.at --- Created attachment 164534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164534&action=edit Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 davewood@gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164531|0 |1 is obsolete| | --- Comment #139 from davewood@gmx.at --- Created attachment 164535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164535&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: David Schmidt <davewood@gmx.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164532|0 |1 is obsolete| | Attachment #164533|0 |1 is obsolete| | Attachment #164534|0 |1 is obsolete| | Attachment #164535|0 |1 is obsolete| | --- Comment #140 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164789&action=edit Bug 20388: Elasticsearch - Ability to add search fields from UI Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #141 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164790&action=edit Bug 20388: Adjust code Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #142 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164791&action=edit Bug 20388: Add trash icon to the delete button Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #143 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164792&action=edit Bug 20388: Alert if the search field already exists Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: David Schmidt <davewood@gmx.at> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #144 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164793&action=edit Bug 20388: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #145 from Nick Clemens <nick@bywatersolutions.com> --- Small notes from testing (for future follow-ups, not here) The 'Add' button cannot be tabbed to - this feels like a small accessibility lack After adding a field, I must save before I can add mappings - seems ok I was able to, in the interface, delete a field with a mapping, but saving gave an error and all was restored - ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #146 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #145)
Small notes from testing (for future follow-ups, not here)
The 'Add' button cannot be tabbed to - this feels like a small accessibility lack After adding a field, I must save before I can add mappings - seems ok I was able to, in the interface, delete a field with a mapping, but saving gave an error and all was restored - ok
Could you please file bugs for these? So we don't lose sight of them. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36609 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #147 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows to release notes| |add search fields from | |Staff Interface under Admin | |> Search engine | |configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows to |This new feature allows to release notes|add search fields from |add search fields from the |Staff Interface under Admin |staff interface under |> Search engine |Administration > Search |configuration |engine configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows to |This new feature for release notes|add search fields from the |Elasticsearch (and Open |staff interface under |Search) lets you add search |Administration > Search |fields using the staff |engine configuration. |interface (Administration > | |Catalog > Search engine | |configuration | |(Elasticsearch)). | |Previously, you needed to | |edit a YAML file on the | |server to change the search | |fields. --- Comment #148 from David Nind <david@davidnind.com> --- I have updated the release notes. Is it a new feature or an enhancement? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #149 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #148)
I have updated the release notes.
Is it a new feature or an enhancement?
I think enh is OK here: we had the ability do to this before, but it got heaps easier now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature for |This enhancement for release notes|Elasticsearch (and Open |Elasticsearch (and Open |Search) lets you add search |Search) lets you add search |fields using the staff |fields using the staff |interface (Administration > |interface (Administration > |Catalog > Search engine |Catalog > Search engine |configuration |configuration |(Elasticsearch)). |(Elasticsearch)). |Previously, you needed to |Previously, you needed to |edit a YAML file on the |edit a YAML file on the |server to change the search |server to change the search |fields. |fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #150 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - Ability to |Ability to add search |add search fields from UI |fields from UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37857 [Bug 37857] Unable to select type "Geo point" or "Call number" when adding a search field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/953 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org