http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 AlexHorsman <dhorsman@xtra.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhorsman@xtra.co.nz --- Comment #1 from AlexHorsman <dhorsman@xtra.co.nz> --- Created attachment 24243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24243&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24243|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 24244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24244&action=edit bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: Liz Rea <liz@catalyst.net.nz> 3 tests are in fact run. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24244|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Comment on attachment 24244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24244 bug 11537: Increasing test coverage for C4::Log Removing, as signoff has to be outside catalyst. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24243|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 24245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24245&action=edit bug 11537: Increasing test coverage for C4::Log To test: 1. run prove t/Log.t Notice 1 test is run 2. apply patch 3. run prove t/Log.t Notice 3 tests are run Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I think there might be a typo in "Testing git log status". Should this read "Testing get log status"? (Noticed while looking at the code/running perl t/Log.t.) In any case, thanks for the patch. Looks good! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Welcome Alex! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11537 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Upon Jenkins (the continuous integration service) complaining, I've also pushed a follow-up that mocks the calls to C4::Context::preference() that C4::Log::GetLogStatus() makes, which will allow the test to pass without requiring that a Koha database is present and pointed to by a valid Koha configuration. -- You are receiving this mail because: You are watching all bug changes.