[Bug 11432] New: 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Bug ID: 11432 Summary: 404.pl redirect for single, hidden result makes no sense. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 23738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23738&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 Assignee|oleonard@myacpl.org |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23879&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Patch works according to test plan. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23879|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24101&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN --------- 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24102&action=edit Bug 11432: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added a followup in order to hide the facets block if no result is displayed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- I'm failing this because it doesn't address the root cause, which is that opac-search.pl is failing to count hits correctly when bibs get filtered out because all of their items are hidden. To see what I mean, try the following test: [1] Arrange a search that returns two hits. [2] Edit the items on one of the bibs so that all of them would be hidden. [3] Run the search. The OPAC will report two hits, but display a result list containing only one hit. It should actually be redirecting to that bib. The root issue is described in bug 8462. Putting aside the notion of further work to materialize the hidden status of the items attached to a bib so that the search engine can filter them out automatically, I think there's room for a patch for that bug that simply arranges so that $total and $hits are calculated correctly; I think that it is a far less productive direction to pile on more code that attempts to work around $total being incorrect. Jonathan: regarding your follow-up, one thing to note is that the Bootstrap theme already -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11489 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Galen, is 11489 the type of patch you were talking about on the IRC channel? If so, perhaps Jonathan Druart's patch combined with 11489 would be the proper solution? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24102|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24293&action=edit [SIGNED OFF] Bug 11432: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- I moved the second patch to bug 11489, and I believe it solves the issues from bug 10584 as well. *** This bug has been marked as a duplicate of bug 11489 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org