[Bug 42741] New: Plural strings don't apply in list content column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Bug ID: 42741 Summary: Plural strings don't apply in list content column Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, f.demians@tamil.fr, jonathan.druart@gmail.com, julian.maurice@biblibre.com I'm not sure if this is a translation problem or simply a code problem... I noticed my plural strings in the lists content display weren't applying. But it seems there is a problem in English as well. To recreate: 1. Go to Lists 2. Create three lists called: - Test 0 items - Test 1 item - Test 2 items 3. Add one item in the "Test 1 item" list and add two items in the "Test 2 items" list 4. Go to lists and view the list of lists --> In the Contents column, "Test 0 items" has "0 items" (items plural -- OK?) --> "Test 1 item" has "1 items" (items plural -- NOT OK) --> "Test 2 items" has "2 items" (items plural -- OK) Optionally test translations 5. In the terminal, run gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA (or other language code that uses plurals) 6. Enable the language in the StaffInterfaceLanguages syspref 7. Check the fr-CA-message.po file (or other language code), the strings should be different for single or plural #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:777 #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:795 #: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt:18 #, perl-brace-format msgid "{count} item" msgid_plural "{count} items" msgstr[0] "{count} exemplaire" msgstr[1] "{count} exemplaires" I don't get why in English it's always items. In French Canada, it seems to be always exemplaire (singular). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- It's a code problem. I'll send a patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 199798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199798&action=edit Bug 42741: Fix plural form in lists Test plan: 1. Go to Lists 2. Create three lists called: - Test 0 items - Test 1 item - Test 2 items 3. Add one item in the "Test 1 item" list and add two items in the "Test 2 items" list 4. Go to lists and view the list of lists --> In the Contents column, "Test 0 items" should be "0 items" --> "Test 1 item" should be "1 item" --> "Test 2 items" should be "2 items" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- I was going to attach the exact same patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199802&action=edit Bug 42741: Fix plural form in lists Test plan: 1. Go to Lists 2. Create three lists called: - Test 0 items - Test 1 item - Test 2 items 3. Add one item in the "Test 1 item" list and add two items in the "Test 2 items" list 4. Go to lists and view the list of lists --> In the Contents column, "Test 0 items" should be "0 items" --> "Test 1 item" should be "1 item" --> "Test 2 items" should be "2 items" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29602 QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 [Bug 29602] We must be nicer with translators -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42741 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org