https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 197491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197491&action=edit Bug 42395: Fix missing translations on load_patron_holds_table This patch adds missing translations for the load_patron_holds_table function. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |translatability of strings | |for the existing holds | |table in the staff | |interface for a record | |(Staff interface > [details | |page for a record] > Holds | |> Existing holds). | | | |These strings were not | |previously translated: | |- Priority column: In | |transit, Waiting, and In | |processing | |- Change priority column: | |tooltip text for arrows: | | . Move hold up | | . Move hold to top | | . Move hold to bottom | | . Move hold down Summary|Missing translations on |Missing translations for |load_patron_holds_table |the existing holds table | |(load_patron_holds_table) | |for a record in the staff | |interface CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Install any translation: sudo koha-translate --install de-DE --dev kohadev 2. Activate the translation for the staff interface using the StaffInterfaceLanguages system preference 3. Steps to get the text that needs translating to show for the record holds table: - Waiting: Place a hold, fill the hold (check in), shows as "Waiting" in the priority column ((I used Perl template toolkit, biblionumber = 255)) - In transit: Place an item-level hold for an item in a different library than the patron, check it in, confirm transfer - In processing (no idea how to get this to show) 4. Hover above the up and down arrows for the "Change priority" column to see the text: - Move hold up - Move hold to top - Move hold to bottom - Move hold down 5. Switch to the language installed for the staff interface. 6. Repeat steps 4 and 5, and note that the text is not translated. 7. Apply the patch. 8. Update the translated language: - Update the translation .po files with the new strings: gulp po:update --lang de-DE - Edit the misc/translator/po/de-DE-messages-js.po file . Search for the previously untranslated text . Remove the "#, fuzzy" line for the text . Add some text in the mgstr for those don't have a translation - Update the translation: sudo koha-translate --update de-DE --dev kohadev 9. Restart everything: restart_all 10. Repeat steps 4 and 5 using the language installed. 11. The translated text should now be shown. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described and adheres to the coding guideline: JS5: Enabling translation of language strings in linked JavaScript. Thanks for the detailed test plan David! I definitely needed the details in step 8. Nice work. Passing QA! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42395 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.