https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48466|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48467&action=edit Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48467|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48607&action=edit Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as expected. No regression. Better texts. Consistent validation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48607|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48609&action=edit Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard <div id="toolbar"> - Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra </div>. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as expected. No regression. Better texts. Consistent validation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Bug 15925 depends on bug 15916, which changed state. Bug 15916 Summary: Regression: Many tables' sorting broken by JavaScript error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.