[Bug 15920] New: Clean up and fix errors in batch checkout template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Bug ID: 15920 Summary: Clean up and fix errors in batch checkout template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 15918 The batch checkout template has some JavaScript and markup errors which should be corrected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 [Bug 15918] Obsolete file datatables-strings.inc can be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48374&action=edit Bug 15920 - Clean up and fix errors in batch checkout template The batch checkout template has some markup and JavaScript problems which need to be resolved, including: - Mismatched <h3></h1> - JavaScript includes which are not used - Incorrect DataTables configuration - Incorrect class on warning dialogs - Incorrect terminology: Use "checkout" instead of "issue" This patch also changes the markup and styling of batch checkout errors, using Font Awesome icons to retain highlighting of warnings and errors while (I hope) improving readability. To test, apply the patch and go to batch checkout for a patron for whom batch checkouts are enabled. - Check out a batch of barcodes. Include items which will trigger errors or warnings. For example: Invalid barcodes, lost items, items which are already checked out, items which are on hold for another patron, items which are damaged. - When the table of items is displayed so that you can confirm the checkout, make sure the table is sortable. - Think about whether the style changes on warnings and errors are an improvement. - Try to initiate a batch checkout to a patron who is restricted. You should see an "alert" style dialog instead of a "message" style one. - Validate the HTML and confirm that there are no errors raised by this template's markup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48411&action=edit Buggy checkout batch Hi Owen For damaged items the warning message is not displayed, and Koha let to checkout the item as shown in the image. I notice about a buggy behavor in this functionallity, for example the program let to checkout the first item available without confirm the checkout message, for example, Maxwell's handbook was borrowed/renewed to this patron every time in which I repeat the process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48412&action=edit Checked-out table result When the process end, you will presented with this table (see image attached), one items was checked-out and the others wasn't, but the message is not clear whether those items was checked out or not. Another thing that I could observe is that in my circ policies I don't have set a fine amount and the program is charging $5.00 to all my check-outs, but I think this is a bug in the circulation and fine policies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Thanks for testing Héctor. Just to be clear: Are these problems caused by my patch? See also Bug 15718. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15718 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 [Bug 15718] Need more information for items that don't successfully batch checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> ---
Thanks for testing Héctor. Just to be clear: Are these problems caused by my patch? See also Bug 15718.
Ahhh, Ok I understand. You're right, the problem persist without your patch. I did the same without your patch and gave me the some results. The make up you did it is much better in addition to the problems you fixed it up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48374|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48413&action=edit [SIGNED-OFF]Bug 15920: Clean up and fix errors in batch checkout template The batch checkout template has some markup and JavaScript problems which need to be resolved, including: - Mismatched <h3></h1> - JavaScript includes which are not used - Incorrect DataTables configuration - Incorrect class on warning dialogs - Incorrect terminology: Use "checkout" instead of "issue" This patch also changes the markup and styling of batch checkout errors, using Font Awesome icons to retain highlighting of warnings and errors while (I hope) improving readability. To test, apply the patch and go to batch checkout for a patron for whom batch checkouts are enabled. - Check out a batch of barcodes. Include items which will trigger errors or warnings. For example: Invalid barcodes, lost items, items which are already checked out, items which are on hold for another patron, items which are damaged. - When the table of items is displayed so that you can confirm the checkout, make sure the table is sortable. - Think about whether the style changes on warnings and errors are an improvement. - Try to initiate a batch checkout to a patron who is restricted. You should see an "alert" style dialog instead of a "message" style one. - Validate the HTML and confirm that there are no errors raised by this template's markup. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48413|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48446&action=edit Bug 15920: Clean up and fix errors in batch checkout template The batch checkout template has some markup and JavaScript problems which need to be resolved, including: - Mismatched <h3></h1> - JavaScript includes which are not used - Incorrect DataTables configuration - Incorrect class on warning dialogs - Incorrect terminology: Use "checkout" instead of "issue" This patch also changes the markup and styling of batch checkout errors, using Font Awesome icons to retain highlighting of warnings and errors while (I hope) improving readability. To test, apply the patch and go to batch checkout for a patron for whom batch checkouts are enabled. - Check out a batch of barcodes. Include items which will trigger errors or warnings. For example: Invalid barcodes, lost items, items which are already checked out, items which are on hold for another patron, items which are damaged. - When the table of items is displayed so that you can confirm the checkout, make sure the table is sortable. - Think about whether the style changes on warnings and errors are an improvement. - Try to initiate a batch checkout to a patron who is restricted. You should see an "alert" style dialog instead of a "message" style one. - Validate the HTML and confirm that there are no errors raised by this template's markup. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 [Bug 15937] Batch checkout buggy behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org