[Bug 21695] New: Clean up access files template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Bug ID: 21695 Summary: Clean up access files template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/access_files.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 20654 The access files template has several issues which need to be cleaned up: - Bootstrap grid - Improve DataTables configuration - Markup corrections Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 [Bug 11317] Add a way to access files from the intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81334&action=edit Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81334|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81536&action=edit Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81536|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82176&action=edit Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org