[Bug 21693] New: Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Bug ID: 21693 Summary: Clean up checkout notes template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/checkout-notes.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 20654 The checkout notes template has several issues which need to be cleaned up: - Bootstrap grid - DataTables configuration improvement - Change toolbar position to better match established patterns Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81320&action=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81321&action=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81321|0 |1 is obsolete| | --- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 81339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81339&action=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81339|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81363&action=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81364&action=edit Bug 21693: Make page title consistent with other pages For some reason we use 'Home' in the bread crumbs, but 'Koha' as starting point in the page title. Changed to make consistent with other pages in Circulation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't make them work with this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81363|0 |1 is obsolete| | Attachment #81364|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82226&action=edit Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82227&action=edit Bug 21693: Make page title consistent with other pages For some reason we use 'Home' in the bread crumbs, but 'Koha' as starting point in the page title. Changed to make consistent with other pages in Circulation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #6)
Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't make them work with this
This was an error in the placement of the <form> tag. That's the only change to the signed-off patch. I hope it's okay to return this to 'Passed QA.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #9)
(In reply to Nick Clemens from comment #6)
Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't make them work with this
This was an error in the placement of the <form> tag. That's the only change to the signed-off patch. I hope it's okay to return this to 'Passed QA.'
Yup,that's okay, would be better as a follow-up patch so that the change can be easily seen and verified, but it works in testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org